[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570559#comment-16570559
]
Chao Sun commented on HDFS-12976:
-
[~xkrogen]: to my understanding, there's 1-1 mapping between
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568861#comment-16568861
]
Erik Krogen commented on HDFS-12976:
Hey [~csun], one follow-up question about these two lines:
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539383#comment-16539383
]
Konstantin Shvachko commented on HDFS-12976:
+1 this looks good.
TestBlockReaderLocal is
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530552#comment-16530552
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530277#comment-16530277
]
Chao Sun commented on HDFS-12976:
-
[~shv]: thanks for the review. I removed the {{performFailover}} logic
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528331#comment-16528331
]
Konstantin Shvachko commented on HDFS-12976:
Hey Chao, you are right there is no need to
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527352#comment-16527352
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527146#comment-16527146
]
Chao Sun commented on HDFS-12976:
-
My bad [~shv]: when merging your change to my local branch I forgot to
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527108#comment-16527108
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527104#comment-16527104
]
Konstantin Shvachko commented on HDFS-12976:
Here is another variant v006, which actually
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525875#comment-16525875
]
Erik Krogen commented on HDFS-12976:
I think to pursue an approach like [~shv]'s, we need to define
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525770#comment-16525770
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525574#comment-16525574
]
Chao Sun commented on HDFS-12976:
-
Thanks for the comments [~xkrogen] and [~shv]!
[~xkrogen]: yes we can
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524459#comment-16524459
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524440#comment-16524440
]
Konstantin Shvachko commented on HDFS-12976:
Hey [~csun]. Took me some time, sorry.
So when
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523422#comment-16523422
]
Erik Krogen commented on HDFS-12976:
Would the flag be something like {{allowObserverReads}}? I am
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522689#comment-16522689
]
Chao Sun commented on HDFS-12976:
-
Another thought I'm thinking is to add a flag in
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519852#comment-16519852
]
Chao Sun commented on HDFS-12976:
-
Good point [~vagarychen]! Will add that check.
[~shv] - back to this
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516480#comment-16516480
]
Chen Liang commented on HDFS-12976:
---
Hey [~csun], I just noticed one more thing: although {{ReadOnly}}
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514962#comment-16514962
]
Chao Sun commented on HDFS-12976:
-
[~shv] Yes, I created HDFS-13687 to fix this. Could you take a look?
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514920#comment-16514920
]
Konstantin Shvachko commented on HDFS-12976:
??{{ConfiguredFailoverProxyProvider}} and
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514067#comment-16514067
]
Chao Sun commented on HDFS-12976:
-
[~xkrogen]: let me know if I misunderstood anything - if someone is
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514055#comment-16514055
]
Erik Krogen commented on HDFS-12976:
Hey [~csun], I don't see why the changes to
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513625#comment-16513625
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513373#comment-16513373
]
Chao Sun commented on HDFS-12976:
-
Adopted [~shv]'s suggestion and attached patch v3. The
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513349#comment-16513349
]
Chao Sun commented on HDFS-12976:
-
Yes that's the issue. However, if we keep the logic in
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513218#comment-16513218
]
Konstantin Shvachko commented on HDFS-12976:
Hey [~csun] looked at the test failures. I think
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511612#comment-16511612
]
Chao Sun commented on HDFS-12976:
-
Hmm.. there are some test failures that are related. Will fix and
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511585#comment-16511585
]
genericqa commented on HDFS-12976:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511293#comment-16511293
]
Chao Sun commented on HDFS-12976:
-
Oops, my bad. Thanks [~xkrogen]!
> Introduce
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511253#comment-16511253
]
Erik Krogen commented on HDFS-12976:
[~csun], you need to put the JIRA into patch available state for
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510679#comment-16510679
]
Chao Sun commented on HDFS-12976:
-
Thanks [~shv]. Addressed the issues (should have enabled the
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508739#comment-16508739
]
Konstantin Shvachko commented on HDFS-12976:
Hey Chao, there is still non-parametrized use of
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508546#comment-16508546
]
Chao Sun commented on HDFS-12976:
-
Merged trunk into HDFS-12943 and uploaded patch v1.
> Introduce
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508426#comment-16508426
]
Chao Sun commented on HDFS-12976:
-
Thanks [~xkrogen], [~vagarychen] and [~shv], for the very helpful
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508344#comment-16508344
]
Chen Liang commented on HDFS-12976:
---
Thanks for pointing it out [~xkrogen]. I was not reading into
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508270#comment-16508270
]
Erik Krogen commented on HDFS-12976:
{quote}
The thing is that, the current patch looks at ReadOnly
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507165#comment-16507165
]
Konstantin Shvachko commented on HDFS-12976:
[~csun] the patch looks good to me except
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506715#comment-16506715
]
Konstantin Shvachko commented on HDFS-12976:
Committed HDFS-13664 with the refactoring. You
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506688#comment-16506688
]
Chen Liang commented on HDFS-12976:
---
Hey [~csun],
I've got another thought when thinking of how
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506350#comment-16506350
]
Erik Krogen commented on HDFS-12976:
My inclination for handling this race condition is to instead
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506297#comment-16506297
]
Chao Sun commented on HDFS-12976:
-
Hey [~xkrogen]. Thanks for the feedback. The reason for keeping
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506284#comment-16506284
]
Erik Krogen commented on HDFS-12976:
Thanks for taking this on [~csun]! I have two overall comments.
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505606#comment-16505606
]
Chao Sun commented on HDFS-12976:
-
Thanks. I'll create a JIRA for the refactoring. One minor issue is
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505573#comment-16505573
]
Konstantin Shvachko commented on HDFS-12976:
Also for slf4j loggers you should use
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505551#comment-16505551
]
Konstantin Shvachko commented on HDFS-12976:
Totally makes sense to commit the refactor of
[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505511#comment-16505511
]
Íñigo Goiri commented on HDFS-12976:
bq. I can extract this and put it in a separate JIRA. It should
47 matches
Mail list logo
