[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-10-01 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634725#comment-16634725 ] Wei-Chiu Chuang commented on HDFS-13052: Additionally I found a few minor bugs in HDFS-12594 in

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-10-01 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634722#comment-16634722 ] Wei-Chiu Chuang commented on HDFS-13052: [~renxunsaky] thanks for the tips. I actually didn't

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-10-01 Thread Xun REN (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634559#comment-16634559 ] Xun REN commented on HDFS-13052: Hi [~jojochuang], Thanks for this comment. So If I understand well,

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-10-01 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634060#comment-16634060 ] Wei-Chiu Chuang commented on HDFS-13052: I'm late to review this (coming from HDFS-13877). While

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-09-27 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630743#comment-16630743 ] Xiaoyu Yao commented on HDFS-13052: --- Thanks [~renxunsaky] for reporting the issue. This ticket adds

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-09-12 Thread Xun REN (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612146#comment-16612146 ] Xun REN commented on HDFS-13052: Hi [~xyao], [~ljain]   I see in the source code:

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375294#comment-16375294 ] Hudson commented on HDFS-13052: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13713 (See

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-23 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374688#comment-16374688 ] Xiaoyu Yao commented on HDFS-13052: --- [~ljain], the Jenkins run looks good. The test failure does not

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374029#comment-16374029 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-22 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373908#comment-16373908 ] Xiaoyu Yao commented on HDFS-13052: --- [~ljain], I manually trigger a Jenkins run for this one. Thanks! >

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-14 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363648#comment-16363648 ] Lokesh Jain commented on HDFS-13052: [~xyao] the checkstyle issues appear in NamenodeWebHdfsMethods

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-13 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363105#comment-16363105 ] Xiaoyu Yao commented on HDFS-13052: --- [~ljain], can you fix the checkstyle issue? The patch v7 LGTM, +1

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362820#comment-16362820 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-13 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362356#comment-16362356 ] Lokesh Jain commented on HDFS-13052: v7 patch uses DFSUtilClient string to bytes[] conversion

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361294#comment-16361294 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-12 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360963#comment-16360963 ] Lokesh Jain commented on HDFS-13052: v6 patch adds a function in JsonUtil to convert

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359597#comment-16359597 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359483#comment-16359483 ] Lokesh Jain commented on HDFS-13052: [~xyao] Thanks for pointing it out! v5 patch addresses your

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-09 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358819#comment-16358819 ] Xiaoyu Yao commented on HDFS-13052: --- Thanks [~ljain] for the update. Patch v4 looks mostly good. I have

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358333#comment-16358333 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-09 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358130#comment-16358130 ] Lokesh Jain commented on HDFS-13052: [~xyao] Thanks for reviewing the patch! v4 patch addresses your

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-02-08 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357729#comment-16357729 ] Xiaoyu Yao commented on HDFS-13052: --- Thanks [~ljain] for working on this. The patch looks good to me

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-01-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343680#comment-16343680 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-01-29 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343428#comment-16343428 ] Lokesh Jain commented on HDFS-13052: v3 patch fixes checkstyle issues. Unit test failures are not

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-01-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343109#comment-16343109 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13052) WebHDFS: Add support for snasphot diff

2018-01-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341963#comment-16341963 ] genericqa commented on HDFS-13052: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||