[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366407#comment-16366407 ] Hudson commented on HDFS-13112: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13666 (See

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-15 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366307#comment-16366307 ] Kihwal Lee commented on HDFS-13112: --- Committed this to trunk, branch-3.1, branch-3.0, branch-3.0.1,

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-15 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366274#comment-16366274 ] Kihwal Lee commented on HDFS-13112: --- Will commit it shortly. > Token expiration edits may cause log

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-15 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366261#comment-16366261 ] Xiao Chen commented on HDFS-13112: -- Thanks for the comments Daryn. Given this really is just update

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-15 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366049#comment-16366049 ] Daryn Sharp commented on HDFS-13112: Xiao, good questions. Yes, typically the edit log should not be

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-09 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359271#comment-16359271 ] Xiao Chen commented on HDFS-13112: -- Thanks for the fix Daryn and Kihwal. I have not reviewed as careful

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359024#comment-16359024 ] genericqa commented on HDFS-13112: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-09 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358820#comment-16358820 ] Daryn Sharp commented on HDFS-13112: Ok, state transitions hold the write lock when stopping the

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-08 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357180#comment-16357180 ] Kihwal Lee commented on HDFS-13112: --- The handler for {{enterSafeMode}} has acquired a write lock. The

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-08 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357050#comment-16357050 ] Kihwal Lee commented on HDFS-13112: --- When I ran the failed tests, the following is reproduced. It seems

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-07 Thread Kihwal Lee (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355844#comment-16355844 ] Kihwal Lee commented on HDFS-13112: --- The patch looks good. - The addition of read locks ensures these

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-06 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354790#comment-16354790 ] genericqa commented on HDFS-13112: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13112) Token expiration edits may cause log corruption or deadlock

2018-02-06 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354240#comment-16354240 ] Daryn Sharp commented on HDFS-13112: Submit is pending HADOOP-15212. > Token expiration edits may