[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483001#comment-16483001
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~yzhangal] for taking care of this.
>
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481728#comment-16481728
]
Yongjun Zhang commented on HDFS-13388:
--
Hi [~elgoiri],
Thanks for the reply. I just put both
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480934#comment-16480934
]
Íñigo Goiri commented on HDFS-13388:
[~yzhangal], sorry I missed this.
I think it would be best to
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480073#comment-16480073
]
Yongjun Zhang commented on HDFS-13388:
--
HI [~elgoiri],
Would you please take a look at my comment
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470764#comment-16470764
]
Yongjun Zhang commented on HDFS-13388:
--
HI [~elgoiri],
Thanks for staying on top. I have been doing
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470658#comment-16470658
]
Íñigo Goiri commented on HDFS-13388:
I reverted this from branch-3.0 for now.
Not sure if it's fine to
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470293#comment-16470293
]
Bibin A Chundatt commented on HDFS-13388:
-
Since HDFS-12813 is long back closed might need a
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470001#comment-16470001
]
Íñigo Goiri commented on HDFS-13388:
My bad... I remember I had to fix that before.
[~bibinchundatt],
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469901#comment-16469901
]
Bibin A Chundatt commented on HDFS-13388:
-
[~yzhangal]
branch-3 compilation is broken
{code}
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469583#comment-16469583
]
Yongjun Zhang commented on HDFS-13388:
--
Welcome, and thanks for taking care of that, [~elgoiri]. I
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469488#comment-16469488
]
Íñigo Goiri commented on HDFS-13388:
bq. This Jira was released in 3.0.2 then get reverted from
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469299#comment-16469299
]
Yongjun Zhang commented on HDFS-13388:
--
Hi [~elgoiri],
This Jira was released in 3.0.2 then get
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447508#comment-16447508
]
Hudson commented on HDFS-13388:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14044 (See
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447490#comment-16447490
]
Íñigo Goiri commented on HDFS-13388:
+1 on [^HADOOP-13388.0014.patch].
Committing to trunk; let me
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447450#comment-16447450
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri], are you comfortable committing this?
>
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440288#comment-16440288
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440234#comment-16440234
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri], I give an update at patch 0014. I'm comfortable committing
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439679#comment-16439679
]
Íñigo Goiri commented on HDFS-13388:
[^HADOOP-13388.0013.patch] LGTM.
A minor nit is that:
{code}
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438963#comment-16438963
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438934#comment-16438934
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri] for your comments, I learned a lot from them. I upload
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437468#comment-16437468
]
Íñigo Goiri commented on HDFS-13388:
Yetus build is clean and it looks like the test run
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436856#comment-16436856
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436761#comment-16436761
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri] for comments. I updates the test case for static
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436733#comment-16436733
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436696#comment-16436696
]
Íñigo Goiri commented on HDFS-13388:
Minor comments on [^HADOOP-13388.0011.patch].
* The bad mock
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436029#comment-16436029
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435945#comment-16435945
]
Hudson commented on HDFS-13388:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13985 (See
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435868#comment-16435868
]
genericqa commented on HDFS-13388:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435809#comment-16435809
]
Íñigo Goiri commented on HDFS-13388:
I reuploaded [^HADOOP-13388.0009.patch] as
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435797#comment-16435797
]
Íñigo Goiri commented on HDFS-13388:
[~LiJinglun], I went ahead with the revert.
Let's see if Yetus
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434908#comment-16434908
]
genericqa commented on HDFS-13388:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434848#comment-16434848
]
genericqa commented on HDFS-13388:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434817#comment-16434817
]
Jinglun commented on HDFS-13388:
hi [~elgoiri], patch 007 is an addendum for what we committed. I prefer
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434239#comment-16434239
]
Íñigo Goiri commented on HDFS-13388:
[~LiJinglun], this would be an addendum on top of what we have
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433934#comment-16433934
]
genericqa commented on HDFS-13388:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433855#comment-16433855
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri], I find a bug of 0006.patch: the InvocationTargetException
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433325#comment-16433325
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri]. Keeping the patch in trunk would be enough for me. :)
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432594#comment-16432594
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~rakeshr] for reporting.
Reverted from branch-3.0 too.
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432586#comment-16432586
]
Rakesh R commented on HDFS-13388:
-
Hi [~elgoiri], {{branch-3.0}} also has compilation errors.
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432503#comment-16432503
]
Íñigo Goiri commented on HDFS-13388:
Actually, branch-2 is fine as the rename of the variable is
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432428#comment-16432428
]
Íñigo Goiri commented on HDFS-13388:
Let me revert it from branch-2 and branch-2.9.
[~LiJinglun], if
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432185#comment-16432185
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri], [~Sammi] , the problem is the variable represents the
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431908#comment-16431908
]
SammiChen commented on HDFS-13388:
--
Hi [~LiJinglun] and [~elgoiri], branch-2.9 suffers build failure
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430849#comment-16430849
]
Hudson commented on HDFS-13388:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13943 (See
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430799#comment-16430799
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~LiJinglun] for the patch.
Committed to trunk,
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429977#comment-16429977
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri] for all your comments and patience. :)
>
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429955#comment-16429955
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429943#comment-16429943
]
Íñigo Goiri commented on HDFS-13388:
+1 on [^HADOOP-13388.0006.patch].
If nobody else has comments I
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429837#comment-16429837
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~LiJinglun] for [^HADOOP-13388.0005.patch].
In the
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429701#comment-16429701
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri], thanks for your comment. I changed assertTrue to
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429688#comment-16429688
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429652#comment-16429652
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429620#comment-16429620
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~LiJinglun], minor comment. When we do
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429593#comment-16429593
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri] , thanks for your advice. I update the patch with static
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429591#comment-16429591
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425841#comment-16425841
]
Íñigo Goiri commented on HDFS-13388:
[~LiJinglun], replacing the static for everybody in the class is
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425043#comment-16425043
]
Jinglun commented on HDFS-13388:
Hi [~elgoiri] [~linyiqun], seems good this time.
>
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425017#comment-16425017
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424929#comment-16424929
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri] [~linyiqun] for suggestions. I would do the fix and
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424920#comment-16424920
]
Íñigo Goiri commented on HDFS-13388:
[~LiJinglun], regarding the static import, instead of doing a
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424907#comment-16424907
]
Yiqun Lin commented on HDFS-13388:
--
Hi [~LiJinglun],
{quote}I'm new to Hadoop Community and not knowning
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424875#comment-16424875
]
Jinglun commented on HDFS-13388:
Thanks [~elgoiri] for review. I'm new to Hadoop Community and not
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424225#comment-16424225
]
Íñigo Goiri commented on HDFS-13388:
Thanks [~LiJinglun] for [^HADOOP-13388.0001.patch] .
Other than
[
https://issues.apache.org/jira/browse/HDFS-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423945#comment-16423945
]
genericqa commented on HDFS-13388:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
64 matches
Mail list logo
