[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479701#comment-16479701 ] Hudson commented on HDFS-13558: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14223 (See

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479663#comment-16479663 ] Íñigo Goiri commented on HDFS-13558: [^HDFS-13558.004.patch] LGTM. The failed unit tests are

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread Giovanni Matteo Fumarola (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479641#comment-16479641 ] Giovanni Matteo Fumarola commented on HDFS-13558: - Thanks [~huanbang1993] for working on

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479552#comment-16479552 ] genericqa commented on HDFS-13558: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread Anbang Hu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479339#comment-16479339 ] Anbang Hu commented on HDFS-13558: -- Thanks [~elgoiri] for the careful review. [^HDFS-13558.004.patch] is

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-17 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479299#comment-16479299 ] Íñigo Goiri commented on HDFS-13558: Sorry to do this but... can we put the = null inside of the if?

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478544#comment-16478544 ] genericqa commented on HDFS-13558: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread Anbang Hu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478399#comment-16478399 ] Anbang Hu commented on HDFS-13558: -- Thanks [~elgoiri] for bringing up a good point. cluster is set to

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478392#comment-16478392 ] Íñigo Goiri commented on HDFS-13558: [^HDFS-13558.002.patch] looks good and the unit tests are

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478384#comment-16478384 ] genericqa commented on HDFS-13558: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread Anbang Hu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478245#comment-16478245 ] Anbang Hu commented on HDFS-13558: -- Thanks [~elgoiri] for the suggestion. Uploaded a new version 

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477702#comment-16477702 ] Íñigo Goiri commented on HDFS-13558: I think the checkstyle warning is worth addressing: The two

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-16 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477080#comment-16477080 ] genericqa commented on HDFS-13558: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-15 Thread Anbang Hu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476881#comment-16476881 ] Anbang Hu commented on HDFS-13558: -- Updated patch [^HDFS-13558.001.patch] is uploaded per [~elgoiri]'s

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-15 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476160#comment-16476160 ] Íñigo Goiri commented on HDFS-13558: For the record, this also fails in the [Windows daily

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-14 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475282#comment-16475282 ] genericqa commented on HDFS-13558: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13558) TestDatanodeHttpXFrame does not shut down cluster

2018-05-14 Thread JIRA
[ https://issues.apache.org/jira/browse/HDFS-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475194#comment-16475194 ] Íñigo Goiri commented on HDFS-13558: Thanks [~huanbang1993] for [^HDFS-13558.000.patch]. It may make