[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487697#comment-16487697
 ] 

Hudson commented on HDFS-13588:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14268 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14268/])
HDFS-13588. Fix TestFsDatasetImpl test failures on Windows. Contributed 
(inigoiri: rev c0c9b7a8ef2618b7641a0452d9277abd26815de2)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java


> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Fix For: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.3
>
> Attachments: HDFS-13588-branch-2.000.patch, HDFS-13588.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487602#comment-16487602
 ] 

Íñigo Goiri commented on HDFS-13588:


Thanks [~surmountian] for the explanation.
This makes sense.
The failed unit tests seem unrelated.
+1 on  [^HDFS-13588.000.patch] and  [^HDFS-13588-branch-2.000.patch].
Committing.

> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Attachments: HDFS-13588-branch-2.000.patch, HDFS-13588.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-22 Thread Xiao Liang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484714#comment-16484714
 ] 

Xiao Liang commented on HDFS-13588:
---

For 1, according to the description of 
org.apache.hadoop.fs.FileUtil#setWritable, File#setWritable does not work as 
expected on Windows, but it's used and failed in TestFsDatasetImpl, this fix is 
to replace File#setWritable with org.apache.hadoop.fs.FileUtil#setWritable and 
make it pass on Windows.

For 2, similar to other test case failures on Windows using MiniDFSCluster that 
use a fixed path for different test cases, this fix is to used a randomized 
path for base dir of MiniDFSCluster(introduced in HDFS-13408) to avoid the 
failure due to conflict between test cases.

> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Attachments: HDFS-13588-branch-2.000.patch, HDFS-13588.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-18 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480868#comment-16480868
 ] 

Íñigo Goiri commented on HDFS-13588:


[~surmountian], can you give more insights on this fix?

> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Attachments: HDFS-13588-branch-2.000.patch, HDFS-13588.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-17 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480108#comment-16480108
 ] 

genericqa commented on HDFS-13588:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
4s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 30s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 16s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 23s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 29s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.client.impl.TestBlockReaderLocal |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
|   | hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
|   | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDFS-13588 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12924044/HDFS-13588.000.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 023cb1aa1116 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 2f2dd22 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/24255/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/24255/testReport/ |
| Max. process+thread count | 3563 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdf

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-17 Thread Xiao Liang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479989#comment-16479989
 ] 

Xiao Liang commented on HDFS-13588:
---

Yes it does, uploaded [^HDFS-13588.000.patch] for trunk.

> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Attachments: HDFS-13588-branch-2.000.patch, HDFS-13588.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-13588) Fix TestFsDatasetImpl test failures on Windows

2018-05-17 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/HDFS-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479946#comment-16479946
 ] 

Íñigo Goiri commented on HDFS-13588:


Does this issue apply for trunk?

> Fix TestFsDatasetImpl test failures on Windows
> --
>
> Key: HDFS-13588
> URL: https://issues.apache.org/jira/browse/HDFS-13588
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Xiao Liang
>Assignee: Xiao Liang
>Priority: Major
>  Labels: windows
> Attachments: HDFS-13588-branch-2.000.patch
>
>
> Some test cases of TestFsDatasetImpl failed on Windows due to:
>  # using File#setWritable interface;
>  # test directory conflict between test cases (details in HDFS-13408);
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org