[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424818#comment-17424818
]
Janus Chow commented on HDFS-13821:
---
Thanks [~elgoiri] for the comment.
{quote}Can you post a PR
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424576#comment-17424576
]
Íñigo Goiri commented on HDFS-13821:
Thanks [~Symious]; that's significant, a couple of questions:
*
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424511#comment-17424511
]
Janus Chow commented on HDFS-13821:
---
A comparison of the LocalCacheTest result on local PC would be as
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424499#comment-17424499
]
Janus Chow commented on HDFS-13821:
---
The performance bottleneck should be related to the bug mentioned
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905350#comment-16905350
]
Íñigo Goiri commented on HDFS-13821:
>From the description that [~ferhui] had, the source of this is
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904827#comment-16904827
]
xuzq commented on HDFS-13821:
-
Thanks [~elgoiri].
I found the same problem in pressure measuring RBF,
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904823#comment-16904823
]
Íñigo Goiri commented on HDFS-13821:
In the past we always cached so to keep backwards compatibility
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904781#comment-16904781
]
xuzq commented on HDFS-13821:
-
I'm sorry to discuss this again, I think
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588530#comment-16588530
]
Fei Hui commented on HDFS-13821:
[~linyiqun][~elgoiri] Thanks for review & commit
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588349#comment-16588349
]
Hudson commented on HDFS-13821:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #14813 (See
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588345#comment-16588345
]
Yiqun Lin commented on HDFS-13821:
--
Thanks [~elgoiri] for the confirmation. Committing this.
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588065#comment-16588065
]
Íñigo Goiri commented on HDFS-13821:
+1 on [^HDFS-13821.008.patch].
I'd like to eventually improve
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586829#comment-16586829
]
Yiqun Lin commented on HDFS-13821:
--
LGTM, +1. I will hold off the commit to let [~elgoiri] to have a
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586239#comment-16586239
]
genericqa commented on HDFS-13821:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586151#comment-16586151
]
Fei Hui commented on HDFS-13821:
[~linyiqun] Thanks for detail comments
Upload v008 patch
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586114#comment-16586114
]
Yiqun Lin commented on HDFS-13821:
--
[~ferhui], I afraid that you haven't fully addressed my comments:
*
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585829#comment-16585829
]
genericqa commented on HDFS-13821:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585749#comment-16585749
]
Fei Hui commented on HDFS-13821:
[~linyiqun] Thanks.
Upload v007 patch according to your suggestions
>
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585592#comment-16585592
]
genericqa commented on HDFS-13821:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585509#comment-16585509
]
Yiqun Lin commented on HDFS-13821:
--
Thanks [~ferhui] for updating the patch, [~ferhui]. Two comments:
*
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585444#comment-16585444
]
genericqa commented on HDFS-13821:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585401#comment-16585401
]
Fei Hui commented on HDFS-13821:
Upload v005 fix checkstyle
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585386#comment-16585386
]
genericqa commented on HDFS-13821:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585348#comment-16585348
]
Fei Hui commented on HDFS-13821:
[~elgoiri] Thanks. Change the default value and add a unit test
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584701#comment-16584701
]
Íñigo Goiri commented on HDFS-13821:
[^HDFS-13821.003.patch] LGTM.
It might be a little overdone,
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584143#comment-16584143
]
Fei Hui commented on HDFS-13821:
Errors come from HDFS-13790
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583821#comment-16583821
]
genericqa commented on HDFS-13821:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583793#comment-16583793
]
Fei Hui commented on HDFS-13821:
[~elgoiri] Thanks. Fix the code according to your suggestions and fix
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583741#comment-16583741
]
genericqa commented on HDFS-13821:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583684#comment-16583684
]
Íñigo Goiri commented on HDFS-13821:
Thanks [~ferhui] for [^HDFS-13821.002.patch].
I think we could
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583567#comment-16583567
]
Fei Hui commented on HDFS-13821:
[~elgoiri] [~linyiqun] Thanks for so meaningful discussions !
Upload
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583503#comment-16583503
]
Íñigo Goiri commented on HDFS-13821:
[~ferhui], thanks for the results.
They look pretty bad... we
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583469#comment-16583469
]
Fei Hui commented on HDFS-13821:
[~elgoiri] Here's my testing result about localcache
{code:java}
hadoop
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583462#comment-16583462
]
Íñigo Goiri commented on HDFS-13821:
Can we give it a try setting the concurrency level? [~ferhui]
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583288#comment-16583288
]
Yiqun Lin commented on HDFS-13821:
--
I prefer to disable the cache as a temporary approach if we don't
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582848#comment-16582848
]
Íñigo Goiri commented on HDFS-13821:
Let's replace the local cache then. Any proposals?
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580749#comment-16580749
]
Yiqun Lin commented on HDFS-13821:
--
Thanks [~ferhui] for providing the test results!
As [~ferhui]
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579955#comment-16579955
]
Fei Hui commented on HDFS-13821:
[~elgoiri] Thanks for your reply.
{quote}
The hit ratio of the cache
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578297#comment-16578297
]
Íñigo Goiri commented on HDFS-13821:
bq. Profiling LocalCache is interesing, should we adress a new
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578179#comment-16578179
]
Yiqun Lin commented on HDFS-13821:
--
Thanks for describing more, [~ferhui]. I'm +1 for the idea for
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578110#comment-16578110
]
Fei Hui commented on HDFS-13821:
[~elgoiri] Profiling LocalCache is interesing, should we adress a new
[
https://issues.apache.org/jira/browse/HDFS-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577918#comment-16577918
]
Íñigo Goiri commented on HDFS-13821:
I've seen similar situations in the past and that was the reason
42 matches
Mail list logo
