[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907321#comment-16907321
]
Hudson commented on HDFS-14595:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17119 (See
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906747#comment-16906747
]
Wei-Chiu Chuang commented on HDFS-14595:
+1
> HDFS-11848 breaks API compatibility
>
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906237#comment-16906237
]
Ayush Saxena commented on HDFS-14595:
-
Thanx [~smeng] for the patch v006 LGTM.
[~jojochuang] any
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905869#comment-16905869
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905787#comment-16905787
]
Siyao Meng commented on HDFS-14595:
---
[~ayushtkn] Oddly TestStripedFileAppend was the only place to use
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904509#comment-16904509
]
Ayush Saxena commented on HDFS-14595:
-
Thanx [~smeng] Almost LGTM, just like
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904391#comment-16904391
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904384#comment-16904384
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904342#comment-16904342
]
Ayush Saxena commented on HDFS-14595:
-
Will adding something like
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904333#comment-16904333
]
Ayush Saxena commented on HDFS-14595:
-
Yes, the ones you added. We should atleast trigger those in a
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904332#comment-16904332
]
Siyao Meng commented on HDFS-14595:
---
[~ayushtkn] I believe adding UT for new methods should be in
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904327#comment-16904327
]
Ayush Saxena commented on HDFS-14595:
-
Would be good if we extend a UT for the newly added methods
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904196#comment-16904196
]
Wei-Chiu Chuang commented on HDFS-14595:
Looks good. [~ayushtkn] anything you'd like to add?
>
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903762#comment-16903762
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891368#comment-16891368
]
Siyao Meng commented on HDFS-14595:
---
[~ayushtkn] Makes sense. I'll post a new patch soon.
> HDFS-11848
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889987#comment-16889987
]
Ayush Saxena commented on HDFS-14595:
-
I guess to avoid the incompatibility, we just need to ensure
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889291#comment-16889291
]
Wei-Chiu Chuang commented on HDFS-14595:
LGTM
[~ayushtkn] anything else you'd like to add?
>
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884278#comment-16884278
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883462#comment-16883462
]
Wei-Chiu Chuang commented on HDFS-14595:
Thanks. Let's update the test to use the new API.
>
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883189#comment-16883189
]
Siyao Meng commented on HDFS-14595:
---
[~ayushtkn] Thanks for the review.
I'm adding this API back
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882904#comment-16882904
]
Ayush Saxena commented on HDFS-14595:
-
Will not doing just :
{code:java}
@Deprecated
public
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882843#comment-16882843
]
Siyao Meng commented on HDFS-14595:
---
[~jojochuang] Thanks for reviewing.
I deprecated
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882517#comment-16882517
]
Wei-Chiu Chuang commented on HDFS-14595:
Thanks [~smeng].
bq. Shall we file a separate jira for
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881604#comment-16881604
]
Hadoop QA commented on HDFS-14595:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881499#comment-16881499
]
Siyao Meng commented on HDFS-14595:
---
Shall we file a separate jira for updating the release doc?
[
https://issues.apache.org/jira/browse/HDFS-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869635#comment-16869635
]
Wei-Chiu Chuang commented on HDFS-14595:
Attach the API compat report: [^hadoop_
26 matches
Mail list logo
