[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007828#comment-17007828
]
Chen Liang commented on HDFS-14655:
---
HDFS-14934 does look like the fix. Thanks for the pointer
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007665#comment-17007665
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~vagarychen] for sharing. I think this should be fixed
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007662#comment-17007662
]
Chen Liang commented on HDFS-14655:
---
[~ayushtkn] shared below, it may not help too much though, as it
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004234#comment-17004234
]
Ayush Saxena commented on HDFS-14655:
-
[~vagarychen] can you share the log trace?
> [SBN Read]
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973655#comment-16973655
]
Chen Liang commented on HDFS-14655:
---
[~xkrogen] seems like a different message, looks to me that this
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973496#comment-16973496
]
Erik Krogen commented on HDFS-14655:
[~vagarychen] is that different from the issue reported in
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972701#comment-16972701
]
Chen Liang commented on HDFS-14655:
---
We have this fix in our deployment, one thing I found is that it
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959529#comment-16959529
]
Takanobu Asanuma commented on HDFS-14655:
-
This issue may cause HDFS-14934.
> [SBN Read]
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947051#comment-16947051
]
Erik Krogen commented on HDFS-14655:
Thanks [~ayushtkn]!
> [SBN Read] Namenode crashes if one of The
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946600#comment-16946600
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~xkrogen]
Fixed checkstyle and pushed to branch-2.
>
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946569#comment-16946569
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945995#comment-16945995
]
Erik Krogen commented on HDFS-14655:
Got it. +1 from me on the branch-2 patch but can we fix the two
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942421#comment-16942421
]
Ayush Saxena commented on HDFS-14655:
-
In the test, Lambda Expression was to be replaced and in the
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942305#comment-16942305
]
Erik Krogen commented on HDFS-14655:
Thanks [~ayushtkn]! Would you mind explaining any major
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942268#comment-16942268
]
Ayush Saxena commented on HDFS-14655:
-
Two Checkstyle warning, I need to fix.
[~xkrogen] can you
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942257#comment-16942257
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942191#comment-16942191
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942108#comment-16942108
]
Erik Krogen commented on HDFS-14655:
Hi [~ayushtkn], are you still working on the backport?
> [SBN
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937166#comment-16937166
]
Ayush Saxena commented on HDFS-14655:
-
Sure [~xkrogen] would shoot a branch-2 patch for it in a
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937164#comment-16937164
]
Hudson commented on HDFS-14655:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17373 (See
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937151#comment-16937151
]
Erik Krogen commented on HDFS-14655:
Thank you [~ayushtkn]! Would you be open to helping us get this
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937150#comment-16937150
]
Ayush Saxena commented on HDFS-14655:
-
Committed to trunk, 3.2 and 3.1
Thanx [~vinayakumarb] [~shv]
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937134#comment-16937134
]
Vinayakumar B commented on HDFS-14655:
--
+1
> [SBN Read] Namenode crashes if one of The JN is down
>
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936192#comment-16936192
]
Konstantin Shvachko commented on HDFS-14655:
+1 Yes it does work as expected now for me.
>
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935960#comment-16935960
]
Ayush Saxena commented on HDFS-14655:
-
Test failure seems unrelated.
[~vinayakumarb] [~shv] any
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935198#comment-16935198
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935133#comment-16935133
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~vinayakumarb]for the review.
Have made the suggested
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935114#comment-16935114
]
Vinayakumar B commented on HDFS-14655:
--
Thanks [~ayushtkn] for detailed investigation and patch.
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933585#comment-16933585
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~shv] and [~xkrogen].
I too verified by reverting and
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933556#comment-16933556
]
Erik Krogen commented on HDFS-14655:
[~shv] I previously tried the same (revert the production code
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932926#comment-16932926
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932900#comment-16932900
]
Konstantin Shvachko commented on HDFS-14655:
Hey guys I could not reproduce the problem with
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932879#comment-16932879
]
Erik Krogen commented on HDFS-14655:
Awesome! +1 from me. [~shv], does it look okay to you after the
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932876#comment-16932876
]
Ayush Saxena commented on HDFS-14655:
-
looks better. updated in v07.
> [SBN Read] Namenode crashes
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932810#comment-16932810
]
Erik Krogen commented on HDFS-14655:
v6 LGTM! If you want, I think the thread counting can be
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932789#comment-16932789
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~xkrogen] for the review.
Have made said changes in the
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932729#comment-16932729
]
Erik Krogen commented on HDFS-14655:
Thanks for adding a test [~ayushtkn]! I'm worried about using
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932679#comment-16932679
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932459#comment-16932459
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~shv]
Have added a UT(thanks to Chen, used parts from
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931797#comment-16931797
]
Konstantin Shvachko commented on HDFS-14655:
Hey guys, would it possible to add a test case?
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931684#comment-16931684
]
Ayush Saxena commented on HDFS-14655:
-
[~xkrogen] [~vagarychen] [~shv] any further comments...
>
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928036#comment-16928036
]
Hadoop QA commented on HDFS-14655:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927923#comment-16927923
]
Ayush Saxena commented on HDFS-14655:
-
No issues, We can definitely wait. It would be good if we can
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927910#comment-16927910
]
Erik Krogen commented on HDFS-14655:
Agreed, I think we are saying the same thing. I'm +1 on v004
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927900#comment-16927900
]
Ayush Saxena commented on HDFS-14655:
-
Yes, As I said above too, It interrupts But doesn’t kill,m
>
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927896#comment-16927896
]
Erik Krogen commented on HDFS-14655:
Hm. I believe that when you call {{cancel()}} on the
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927854#comment-16927854
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~xkrogen], Well we can change it to 60 seconds. I guess
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925848#comment-16925848
]
Erik Krogen commented on HDFS-14655:
Looks better to me, thanks [~ayushtkn]! I do think we should
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924675#comment-16924675
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~xkrogen], Have uploaded v3 with said change.
> [SBN
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924650#comment-16924650
]
Erik Krogen commented on HDFS-14655:
v2 looks good to me except that I don't think
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924632#comment-16924632
]
Ayush Saxena commented on HDFS-14655:
-
Thanx [~vagarychen] [~xkrogen] for the discussion. I agree in
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923663#comment-16923663
]
Chen Liang commented on HDFS-14655:
---
[~xkrogen] I agree. But in the particular case here, the only
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923658#comment-16923658
]
Erik Krogen commented on HDFS-14655:
[~chliang] I don't think we want a fixed thread pool, something
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923657#comment-16923657
]
Chen Liang commented on HDFS-14655:
---
[~xkrogen] IIUC, {{IPCLoggerChannel}} here is used on per JN
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923653#comment-16923653
]
Chen Liang commented on HDFS-14655:
---
Thanks for working on this [~ayushtkn]! v01 patch LGTM overall,
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923651#comment-16923651
]
Erik Krogen commented on HDFS-14655:
[~ayushtkn] isn't 1 thread insufficient to perform the calls in
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923637#comment-16923637
]
Ayush Saxena commented on HDFS-14655:
-
[~xkrogen] [~surendrasingh] can you give a look?
> [SBN
[
https://issues.apache.org/jira/browse/HDFS-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920126#comment-16920126
]
Ayush Saxena commented on HDFS-14655:
-
Have uploaded patch to limit thread as of now to 1, We can
58 matches
Mail list logo