[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967228#comment-16967228 ] Hudson commented on HDFS-14938: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17606 (See

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967224#comment-16967224 ] Ayush Saxena commented on HDFS-14938: - Committed to trunk. Thanx [~leosun08] for the contribution and

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-04 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967047#comment-16967047 ] Íñigo Goiri commented on HDFS-14938: +1 on [^HDFS-14938.007.patch]. > Add check if excludedNodes

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966444#comment-16966444 ] Ayush Saxena commented on HDFS-14938: - Thanx [~leosun08] seems fair enough to me. v007 LGTM +1 > Add

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965630#comment-16965630 ] Hadoop QA commented on HDFS-14938: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965627#comment-16965627 ] Hadoop QA commented on HDFS-14938: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965604#comment-16965604 ] Lisheng Sun commented on HDFS-14938: Thanks [~ayushtkn] for checking carefully. updated the patch

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965601#comment-16965601 ] Ayush Saxena commented on HDFS-14938: - {code:java} + * Tests it should getting no node, if if a

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-03 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965589#comment-16965589 ] Lisheng Sun commented on HDFS-14938: Sorry [~ayushtkn] [~elgoiri] the v005 patch missed the javadoc

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964988#comment-16964988 ] Ayush Saxena commented on HDFS-14938: - [~leosun08] where is the javadoc and the function in v005 as

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-11-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964798#comment-16964798 ] Hadoop QA commented on HDFS-14938: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-31 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964617#comment-16964617 ] Hadoop QA commented on HDFS-14938: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-31 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964530#comment-16964530 ] Lisheng Sun commented on HDFS-14938: Thanks [~elgoiri] for your comments. I add a javadoc and ut for

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-31 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964212#comment-16964212 ] Íñigo Goiri commented on HDFS-14938: Maybe we should add the new test code to a separate function to

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-30 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963568#comment-16963568 ] Lisheng Sun commented on HDFS-14938: hi [~ayushtkn] [~xkrogen] [~elgoiri] Could you help you reiview

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962076#comment-16962076 ] Hadoop QA commented on HDFS-14938: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-29 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961807#comment-16961807 ] Ayush Saxena commented on HDFS-14938: - Thanx [~leosun08] for the patch. Please add a debug log,

[jira] [Commented] (HDFS-14938) Add check if excludedNodes contain scope in DFSNetworkTopology#chooseRandomWithStorageType()

2019-10-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961146#comment-16961146 ] Hadoop QA commented on HDFS-14938: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||