[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098443#comment-14098443 ] Hudson commented on HDFS-6850: -- FAILURE: Integrated in Hadoop-Yarn-trunk #647 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/647/]) HDFS-6850. Move NFS out of order write unit tests into TestWrites class. Contributed by Zhe Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1618091) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestWrites.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Fix For: 2.6.0 Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098606#comment-14098606 ] Hudson commented on HDFS-6850: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1864 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1864/]) HDFS-6850. Move NFS out of order write unit tests into TestWrites class. Contributed by Zhe Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1618091) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestWrites.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Fix For: 2.6.0 Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098640#comment-14098640 ] Hudson commented on HDFS-6850: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1838 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1838/]) HDFS-6850. Move NFS out of order write unit tests into TestWrites class. Contributed by Zhe Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1618091) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestWrites.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Fix For: 2.6.0 Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098708#comment-14098708 ] Zhe Zhang commented on HDFS-6850: - Thanks [~atm] and [~brandonli] for reviewing the patch! Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Fix For: 2.6.0 Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[
https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097566#comment-14097566
]
Aaron T. Myers commented on HDFS-6850:
--
Hey Zhe, the patch looks pretty good to me, thanks for taking care of the TODO.
One question - is there any reason that you didn't include the deletion of
{{TestOutOfOrderWrite.java}} in the patch?
Move NFS out of order write unit tests into TestWrites class
Key: HDFS-6850
URL: https://issues.apache.org/jira/browse/HDFS-6850
Project: Hadoop HDFS
Issue Type: Improvement
Components: nfs
Affects Versions: 3.0.0
Reporter: Zhe Zhang
Assignee: Zhe Zhang
Priority: Minor
Attachments: HDFS-6850.patch
Expanding TestWrites class to include the out of order writing scenario. I
think it is logical to merge the OOO scenario in the TestWrites class instead
of having a separate TestOutOfOrderWrite class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097591#comment-14097591 ] Zhe Zhang commented on HDFS-6850: - The original TestOutOfOrderWrite.java was for manual testing. I'm not sure if anyone still needs it in addition to the new unit testing. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097809#comment-14097809 ] Brandon Li commented on HDFS-6850: -- TestOutOfOrderWrite was created in the early days of the NFS gateway development as one of the manual tests. TestOutOfOrderWrite is more like an end-to-end test with a TCP client. How about removing TestOutOfOrderWrite in a following up JIRA? We can add a different end-to-end non-manual test to replace TestOutOfOrderWrite in the following up JIRA, so it won't block this patch from being committed. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097814#comment-14097814 ] Zhe Zhang commented on HDFS-6850: - [~brandonli] Thanks for the clarification. Sounds good to me. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097863#comment-14097863 ] Brandon Li commented on HDFS-6850: -- Created HDFS-6855 to track the effort of replacing TestOutOfOrderWrite with some end-to-end test with more test cases. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097868#comment-14097868 ] Brandon Li commented on HDFS-6850: -- +1. Thank you, [~zhz] and [~atm]! Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098078#comment-14098078 ] Aaron T. Myers commented on HDFS-6850: -- Great, thanks for the comments, Brandon. +1 from me as well. I'm going to commit this momentarily. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098136#comment-14098136 ] Hudson commented on HDFS-6850: -- FAILURE: Integrated in Hadoop-trunk-Commit #6075 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6075/]) HDFS-6850. Move NFS out of order write unit tests into TestWrites class. Contributed by Zhe Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1618091) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestWrites.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Fix For: 2.6.0 Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[
https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096309#comment-14096309
]
Hadoop QA commented on HDFS-6850:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12661565/HDFS-6850.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7629//console
This message is automatically generated.
Move NFS out of order write unit tests into TestWrites class
Key: HDFS-6850
URL: https://issues.apache.org/jira/browse/HDFS-6850
Project: Hadoop HDFS
Issue Type: Improvement
Components: nfs
Affects Versions: 2.6.0
Reporter: Zhe Zhang
Assignee: Zhe Zhang
Priority: Minor
Attachments: HDFS-6850.patch
Expanding TestWrites class to include the out of order writing scenario. I
think it is logical to merge the OOO scenario in the TestWrites class instead
of having a separate TestOutOfOrderWrite class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[ https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096317#comment-14096317 ] Zhe Zhang commented on HDFS-6850: - The first patch file wasn't correctly generated. Resubmitting now. Move NFS out of order write unit tests into TestWrites class Key: HDFS-6850 URL: https://issues.apache.org/jira/browse/HDFS-6850 Project: Hadoop HDFS Issue Type: Improvement Components: nfs Affects Versions: 3.0.0 Reporter: Zhe Zhang Assignee: Zhe Zhang Priority: Minor Attachments: HDFS-6850.patch Expanding TestWrites class to include the out of order writing scenario. I think it is logical to merge the OOO scenario in the TestWrites class instead of having a separate TestOutOfOrderWrite class. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6850) Move NFS out of order write unit tests into TestWrites class
[
https://issues.apache.org/jira/browse/HDFS-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096379#comment-14096379
]
Hadoop QA commented on HDFS-6850:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12661589/HDFS-6850.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs-nfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7630//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7630//console
This message is automatically generated.
Move NFS out of order write unit tests into TestWrites class
Key: HDFS-6850
URL: https://issues.apache.org/jira/browse/HDFS-6850
Project: Hadoop HDFS
Issue Type: Improvement
Components: nfs
Affects Versions: 3.0.0
Reporter: Zhe Zhang
Assignee: Zhe Zhang
Priority: Minor
Attachments: HDFS-6850.patch
Expanding TestWrites class to include the out of order writing scenario. I
think it is logical to merge the OOO scenario in the TestWrites class instead
of having a separate TestOutOfOrderWrite class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
