[jira] [Commented] (HDFS-8050) Separate the client conf key from DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958704#comment-14958704 ] Tsz Wo Nicholas Sze commented on HDFS-8050: --- We moved some client conf properties to HdfsClientConfigKeys but we have not separated the public conf properties from the private conf properties. HdfsClientConfigKeys is already in o.a.h.hdfs.client, not o.a.h.hdfs.client.impl. > Separate the client conf key from DFSConfigKeys > --- > > Key: HDFS-8050 > URL: https://issues.apache.org/jira/browse/HDFS-8050 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > > Currently, all the conf keys are in DFSConfigKeys. We should separate the > public client DFSConfigKeys to a new class in org.apache.hadoop.hdfs.client > as described by [~wheat9] in HDFS-6566. > For the private conf keys, they may be moved to a new class in > org.apache.hadoop.hdfs.client.impl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8050) Separate the client conf key from DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957015#comment-14957015
]
Steve Loughran commented on HDFS-8050:
--
What's the status of this? Can we have {{HdfsClientConfigKeys}} public? Maybe
even moved out of Impl?
> Separate the client conf key from DFSConfigKeys
> ---
>
> Key: HDFS-8050
> URL: https://issues.apache.org/jira/browse/HDFS-8050
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>
> Currently, all the conf keys are in DFSConfigKeys. We should separate the
> public client DFSConfigKeys to a new class in org.apache.hadoop.hdfs.client
> as described by [~wheat9] in HDFS-6566.
> For the private conf keys, they may be moved to a new class in
> org.apache.hadoop.hdfs.client.impl.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8050) Separate the client conf key from DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484048#comment-14484048 ] Tsz Wo Nicholas Sze commented on HDFS-8050: --- Given past experience, moving stuff out of DFSConfigKeys breaks code downstream. We will deprecate them first. Separate the client conf key from DFSConfigKeys --- Key: HDFS-8050 URL: https://issues.apache.org/jira/browse/HDFS-8050 Project: Hadoop HDFS Issue Type: Sub-task Components: hdfs-client Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Currently, all the conf keys are in DFSConfigKeys. We should separate the public client DFSConfigKeys to a new class in org.apache.hadoop.hdfs.client as described by [~wheat9] in HDFS-6566. For the private conf keys, they may be moved to a new class in org.apache.hadoop.hdfs.client.impl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8050) Separate the client conf key from DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484288#comment-14484288 ] Tsz Wo Nicholas Sze commented on HDFS-8050: --- The patch is going to be big. Will split this into more subtasks. Separate the client conf key from DFSConfigKeys --- Key: HDFS-8050 URL: https://issues.apache.org/jira/browse/HDFS-8050 Project: Hadoop HDFS Issue Type: Sub-task Components: hdfs-client Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze Currently, all the conf keys are in DFSConfigKeys. We should separate the public client DFSConfigKeys to a new class in org.apache.hadoop.hdfs.client as described by [~wheat9] in HDFS-6566. For the private conf keys, they may be moved to a new class in org.apache.hadoop.hdfs.client.impl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8050) Separate the client conf key from DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481674#comment-14481674
]
Steve Loughran commented on HDFS-8050:
--
Given past experience, moving stuff out of {{DFSConfigKeys}} breaks code
downstream.
If the client/impl stuff is split into separate interfaces, then
{{DFSConfigKeys}} must declare itself as implementing/extending all of them, to
pull them back into place
Separate the client conf key from DFSConfigKeys
---
Key: HDFS-8050
URL: https://issues.apache.org/jira/browse/HDFS-8050
Project: Hadoop HDFS
Issue Type: Sub-task
Components: hdfs-client
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
Currently, all the conf keys are in DFSConfigKeys. We should separate the
public client DFSConfigKeys to a new class in org.apache.hadoop.hdfs.client
as described by [~wheat9] in HDFS-6566.
For the private conf keys, they may be moved to a new class in
org.apache.hadoop.hdfs.client.impl.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
