[jira] [Updated] (HDFS-10549) Memory leak if exception happens when closing DFSOutputStream or DFSStripedOutputStream

2016-06-19 Thread Yiqun Lin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDFS-10549:
-
Description: 
As HADOOP-13264 memtioned, the code dfsClient.endFileLease(fileId) in 
{{DFSOutputStream}} will not be executed when the IOException happened in 
{{closeImpl()}}.
{code}
  public void close() throws IOException {
synchronized (this) {
  try (TraceScope ignored =
  dfsClient.newPathTraceScope("DFSOutputStream#close", src)) {
closeImpl();
  }
}
dfsClient.endFileLease(fileId);
}
  }
{code}
This will cause that the files not be closed in {{DFSClient}} and finally lead 
to the memory leak. In {{DFSStripedOutputStream}}, it existed the same problem.

  was:
As HADOOP-13264 memtioned, the code dfsClient.endFileLease(fileId) in {{ 
DFSOutputStream}} will not be executed when the IOException happened in 
{{closeImpl()}}.
{code}
  public void close() throws IOException {
synchronized (this) {
  try (TraceScope ignored =
  dfsClient.newPathTraceScope("DFSOutputStream#close", src)) {
closeImpl();
  }
}
dfsClient.endFileLease(fileId);
}
  }
{code}
This will cause that the files not be closed in {{DFSClient}} and finally lead 
to the memory leak. In {{DFSStripedOutputStream}}, it existed the same problem.


> Memory leak if exception happens when closing DFSOutputStream or 
> DFSStripedOutputStream
> ---
>
> Key: HDFS-10549
> URL: https://issues.apache.org/jira/browse/HDFS-10549
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs-client
>Affects Versions: 2.7.1
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
> Attachments: HDFS-10549.001.patch
>
>
> As HADOOP-13264 memtioned, the code dfsClient.endFileLease(fileId) in 
> {{DFSOutputStream}} will not be executed when the IOException happened in 
> {{closeImpl()}}.
> {code}
>   public void close() throws IOException {
> synchronized (this) {
>   try (TraceScope ignored =
>   dfsClient.newPathTraceScope("DFSOutputStream#close", src)) {
> closeImpl();
>   }
> }
> dfsClient.endFileLease(fileId);
> }
>   }
> {code}
> This will cause that the files not be closed in {{DFSClient}} and finally 
> lead to the memory leak. In {{DFSStripedOutputStream}}, it existed the same 
> problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-10549) Memory leak if exception happens when closing DFSOutputStream or DFSStripedOutputStream

2016-06-19 Thread Yiqun Lin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDFS-10549:
-
Attachment: HDFS-10549.001.patch

> Memory leak if exception happens when closing DFSOutputStream or 
> DFSStripedOutputStream
> ---
>
> Key: HDFS-10549
> URL: https://issues.apache.org/jira/browse/HDFS-10549
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs-client
>Affects Versions: 2.7.1
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
> Attachments: HDFS-10549.001.patch
>
>
> As HADOOP-13264 memtioned, the code dfsClient.endFileLease(fileId) in {{ 
> DFSOutputStream}} will not be executed when the IOException happened in 
> {{closeImpl()}}.
> {code}
>   public void close() throws IOException {
> synchronized (this) {
>   try (TraceScope ignored =
>   dfsClient.newPathTraceScope("DFSOutputStream#close", src)) {
> closeImpl();
>   }
> }
> dfsClient.endFileLease(fileId);
> }
>   }
> {code}
> This will cause that the files not be closed in {{DFSClient}} and finally 
> lead to the memory leak. In {{DFSStripedOutputStream}}, it existed the same 
> problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-10549) Memory leak if exception happens when closing DFSOutputStream or DFSStripedOutputStream

2016-06-19 Thread Yiqun Lin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HDFS-10549:
-
Status: Patch Available  (was: Open)

Attach a initial patch.

> Memory leak if exception happens when closing DFSOutputStream or 
> DFSStripedOutputStream
> ---
>
> Key: HDFS-10549
> URL: https://issues.apache.org/jira/browse/HDFS-10549
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs-client
>Affects Versions: 2.7.1
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
> Attachments: HDFS-10549.001.patch
>
>
> As HADOOP-13264 memtioned, the code dfsClient.endFileLease(fileId) in {{ 
> DFSOutputStream}} will not be executed when the IOException happened in 
> {{closeImpl()}}.
> {code}
>   public void close() throws IOException {
> synchronized (this) {
>   try (TraceScope ignored =
>   dfsClient.newPathTraceScope("DFSOutputStream#close", src)) {
> closeImpl();
>   }
> }
> dfsClient.endFileLease(fileId);
> }
>   }
> {code}
> This will cause that the files not be closed in {{DFSClient}} and finally 
> lead to the memory leak. In {{DFSStripedOutputStream}}, it existed the same 
> problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org