[jira] [Updated] (HDFS-12535) Change the Scope of the Class DFSUtilClient to Private

2017-09-23 Thread Anu Engineer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12535:

   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 3.1.0
   Status: Resolved  (was: Patch Available)

+1. Thank you for the contribution. I have committed this to the trunk.
There are 2 checkstyle warnings, but neither of them are really due to this 
change.
One is saying that we should have a comment for that class and another is about 
the ctor
visibility.  This is just FYI


> Change the Scope of the Class DFSUtilClient to Private
> --
>
> Key: HDFS-12535
> URL: https://issues.apache.org/jira/browse/HDFS-12535
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
> Fix For: 3.1.0
>
> Attachments: HDFS-12535.01.patch
>
>
> # This is being done due to the review comments from HDFS-12486 jira and also 
> as now changed scope of method getConfValue(String defaultValue, String 
> keySuffix, Configuration conf, String... keys)  to public. (As these methods 
> are internally used by hadoop project, limiting it's scope)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-12535) Change the Scope of the Class DFSUtilClient to Private

2017-09-22 Thread Bharat Viswanadham (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bharat Viswanadham updated HDFS-12535:
--
Status: Patch Available  (was: In Progress)

> Change the Scope of the Class DFSUtilClient to Private
> --
>
> Key: HDFS-12535
> URL: https://issues.apache.org/jira/browse/HDFS-12535
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
> Attachments: HDFS-12535.01.patch
>
>
> # This is being done due to the review comments from HDFS-12486 jira and also 
> as now changed scope of method getConfValue(String defaultValue, String 
> keySuffix, Configuration conf, String... keys)  to public. (As these methods 
> are internally used by hadoop project, limiting it's scope)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-12535) Change the Scope of the Class DFSUtilClient to Private

2017-09-22 Thread Bharat Viswanadham (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bharat Viswanadham updated HDFS-12535:
--
Attachment: HDFS-12535.01.patch

> Change the Scope of the Class DFSUtilClient to Private
> --
>
> Key: HDFS-12535
> URL: https://issues.apache.org/jira/browse/HDFS-12535
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
> Attachments: HDFS-12535.01.patch
>
>
> This is being done due to the review comments from HDFS-12486 jira and also 
> as now changed scope of method getConfValue(String defaultValue, String 
> keySuffix, Configuration conf, String... keys)  to public. (As these methods 
> are internally used by hadoop project, limiting it's scope)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-12535) Change the Scope of the Class DFSUtilClient to Private

2017-09-22 Thread Bharat Viswanadham (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bharat Viswanadham updated HDFS-12535:
--
Description: 
# This is being done due to the review comments from HDFS-12486 jira and also 
as now changed scope of method getConfValue(String defaultValue, String 
keySuffix, Configuration conf, String... keys)  to public. (As these methods 
are internally used by hadoop project, limiting it's scope)



  was:
This is being done due to the review comments from HDFS-12486 jira and also as 
now changed scope of method getConfValue(String defaultValue, String keySuffix, 
Configuration conf, String... keys)  to public. (As these methods are 
internally used by hadoop project, limiting it's scope)




> Change the Scope of the Class DFSUtilClient to Private
> --
>
> Key: HDFS-12535
> URL: https://issues.apache.org/jira/browse/HDFS-12535
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
> Attachments: HDFS-12535.01.patch
>
>
> # This is being done due to the review comments from HDFS-12486 jira and also 
> as now changed scope of method getConfValue(String defaultValue, String 
> keySuffix, Configuration conf, String... keys)  to public. (As these methods 
> are internally used by hadoop project, limiting it's scope)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Updated] (HDFS-12535) Change the Scope of the Class DFSUtilClient to Private

2017-09-22 Thread Bharat Viswanadham (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bharat Viswanadham updated HDFS-12535:
--
Summary: Change the Scope of the Class DFSUtilClient to Private  (was: 
Change the Scope of the Class DFSUtilClient to LimitedPrivate)

> Change the Scope of the Class DFSUtilClient to Private
> --
>
> Key: HDFS-12535
> URL: https://issues.apache.org/jira/browse/HDFS-12535
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>
> This is being done due to the review comments from HDFS-12486 jira and also 
> as now changed scope of method getConfValue(String defaultValue, String 
> keySuffix, Configuration conf, String... keys)  to public. (As these methods 
> are internally used by hadoop project, limiting it's scope)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org