[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=315542=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315542 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 20/Sep/19 09:18 Start Date: 20/Sep/19 09:18 Worklog Time Spent: 10m Work Description: nandakumar131 commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-533477555 Thanks @elek for taking care of this! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 315542) Time Spent: 3h 20m (was: 3h 10m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=314934=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314934 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 19/Sep/19 10:01 Start Date: 19/Sep/19 10:01 Worklog Time Spent: 10m Work Description: elek commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314934) Time Spent: 3h 10m (was: 3h) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=314916=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314916 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 19/Sep/19 09:15 Start Date: 19/Sep/19 09:15 Worklog Time Spent: 10m Work Description: elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-533041700 Currently all the checkstyle checks are showing false negative answers. I will commit this with the suggested change (moving checkstyle XML files to the dev-support) if no objections... We can improve it (or switch back to the dedicated project) in follow-up jiras, but we need to fix the checks ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314916) Time Spent: 3h (was: 2h 50m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=314915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314915 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 19/Sep/19 09:11 Start Date: 19/Sep/19 09:11 Worklog Time Spent: 10m Work Description: elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-533041700 Currently all the checkstyle checks are showing false negative answers. I will commit this with the suggested change (moving checkstyle XML files to the dev-support) if no objections... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314915) Time Spent: 2h 50m (was: 2h 40m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312944 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 16/Sep/19 13:09 Start Date: 16/Sep/19 13:09 Worklog Time Spent: 10m Work Description: elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531769422 Thanks @nandakumar131 the update. I would remove the build-tools for now. We can (re)create it when we can see the exact need. I think we can use `hadoop-hdds/dev-support/...` to store the checksyle as of now... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312944) Time Spent: 2h 40m (was: 2.5h) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312532=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312532 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 14/Sep/19 08:03 Start Date: 14/Sep/19 08:03 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531459900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 70 | Maven dependency ordering for branch | | +1 | mvninstall | 1696 | trunk passed | | +1 | compile | 1359 | trunk passed | | -1 | mvnsite | 1093 | root in trunk failed. | | +1 | shadedclient | 4937 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 482 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for patch | | -1 | mvninstall | 26 | root in the patch failed. | | -1 | mvninstall | 25 | hadoop-hdds in the patch failed. | | -1 | mvninstall | 22 | build-tools in the patch failed. | | -1 | compile | 28 | root in the patch failed. | | -1 | javac | 28 | root in the patch failed. | | -1 | mvnsite | 27 | root in the patch failed. | | -1 | whitespace | 0 | The patch 1 line(s) with tabs. | | +1 | xml | 8 | The patch has no ill-formed XML file. | | +1 | shadedclient | 772 | patch has no errors when building and testing our client artifacts. | | -1 | javadoc | 30 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 30 | root in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 6735 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1435 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux 81b07cd59e9d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / e04b8a4 | | Default Java | 1.8.0_222 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/branch-mvnsite-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-mvninstall-hadoop-hdds.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-mvninstall-hadoop-hdds_build-tools.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-compile-root.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-mvnsite-root.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/whitespace-tabs.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/testReport/ | | Max. process+thread count | 455 (vs. ulimit of 5500) | | modules | C: . hadoop-hdds hadoop-hdds/build-tools U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/3/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312531=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312531 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 14/Sep/19 08:02 Start Date: 14/Sep/19 08:02 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r324416600 ## File path: hadoop-hdds/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312531) Time Spent: 2h 20m (was: 2h 10m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312515=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312515 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 14/Sep/19 06:15 Start Date: 14/Sep/19 06:15 Worklog Time Spent: 10m Work Description: nandakumar131 commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531453630 Since we are not using maven artifact anymore, we don't need a new maven module `hadoop-hdds-build-tools` exactly. I'm happy to leave it as it is if we can use this to add more build tools, or else we can remove this module and move the files somewhere else. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312515) Time Spent: 2h 10m (was: 2h) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312514=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312514 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 14/Sep/19 06:11 Start Date: 14/Sep/19 06:11 Worklog Time Spent: 10m Work Description: nandakumar131 commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531453399 Thanks for the suggestion @elek . Modified `pom.ozone.xml` to use the files from the project instead of maven artifact. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312514) Time Spent: 2h (was: 1h 50m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312505=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312505 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 14/Sep/19 05:20 Start Date: 14/Sep/19 05:20 Worklog Time Spent: 10m Work Description: elek commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531450551 Thanks @nandakumar131 the patch. Unfortunately it seems to be failing for me with testing it with the checkstyle.sh. Until now the checkstyle.sh did a `mvn checkstyle:check` without compilation (which made it very fast). But now you should have the build-tools compiled and installed to do a full checkstyle check. I don't know what is the good solution here 1. We can use file references instead of artifact references to define the checkstyle rule files 2. Or we can add the required build-tools install to the checkstyle.sh I liked that it was very fast until know, therefore I would prefer the first one, but there could be other options... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312505) Time Spent: 1h 50m (was: 1h 40m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312004 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 13/Sep/19 12:19 Start Date: 13/Sep/19 12:19 Worklog Time Spent: 10m Work Description: nandakumar131 commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531215152 /retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312004) Time Spent: 1h 40m (was: 1.5h) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312001=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312001 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 13/Sep/19 12:17 Start Date: 13/Sep/19 12:17 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r324165265 ## File path: hadoop-hdds/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> Review comment: whitespace:tabs in line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 312001) Time Spent: 1h 20m (was: 1h 10m) > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=312002=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312002 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 13/Sep/19 12:17 Start Date: 13/Sep/19 12:17 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531214647 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 67 | Maven dependency ordering for branch | | +1 | mvninstall | 1472 | trunk passed | | +1 | compile | 1224 | trunk passed | | -1 | mvnsite | 1118 | root in trunk failed. | | +1 | shadedclient | 4588 | branch has no errors when building and testing our client artifacts. | | -1 | javadoc | 371 | root in trunk failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for patch | | -1 | mvninstall | 27 | root in the patch failed. | | -1 | mvninstall | 23 | hadoop-hdds in the patch failed. | | -1 | mvninstall | 23 | build-tools in the patch failed. | | -1 | compile | 27 | root in the patch failed. | | -1 | javac | 27 | root in the patch failed. | | -1 | mvnsite | 27 | root in the patch failed. | | -1 | whitespace | 0 | The patch 1 line(s) with tabs. | | +1 | xml | 8 | The patch has no ill-formed XML file. | | +1 | shadedclient | 774 | patch has no errors when building and testing our client artifacts. | | -1 | javadoc | 30 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 31 | root in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 6246 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1435 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux 5504c393c11c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 4852a90 | | Default Java | 1.8.0_222 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/branch-mvnsite-root.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/branch-javadoc-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-mvninstall-hadoop-hdds.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-mvninstall-hadoop-hdds_build-tools.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-compile-root.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-mvnsite-root.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/whitespace-tabs.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/testReport/ | | Max. process+thread count | 412 (vs. ulimit of 5500) | | modules | C: . hadoop-hdds hadoop-hdds/build-tools U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311818=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311818 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:39 Start Date: 12/Sep/19 23:39 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#issuecomment-531046239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 136 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 76 | Maven dependency ordering for branch | | +1 | mvninstall | 2041 | trunk passed | | +1 | compile | 1366 | trunk passed | | -1 | mvnsite | 1285 | root in trunk failed. | | +1 | shadedclient | 5556 | branch has no errors when building and testing our client artifacts. | | -1 | javadoc | 376 | root in trunk failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for patch | | -1 | mvninstall | 20 | root in the patch failed. | | -1 | mvninstall | 18 | hadoop-ozone in the patch failed. | | -1 | mvninstall | 16 | build-tools in the patch failed. | | -1 | compile | 20 | root in the patch failed. | | -1 | javac | 20 | root in the patch failed. | | -1 | mvnsite | 20 | root in the patch failed. | | -1 | whitespace | 0 | The patch 5 line(s) with tabs. | | +1 | xml | 7 | The patch has no ill-formed XML file. | | +1 | shadedclient | 856 | patch has no errors when building and testing our client artifacts. | | -1 | javadoc | 22 | root in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 23 | root in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 7318 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1435 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux f31165afa566 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 4852a90 | | Default Java | 1.8.0_212 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/branch-mvnsite-root.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/branch-javadoc-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-mvninstall-hadoop-ozone.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-mvninstall-hadoop-ozone_build-tools.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-compile-root.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-mvnsite-root.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/whitespace-tabs.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/testReport/ | | Max. process+thread count | 333 (vs. ulimit of 5500) | | modules | C: . hadoop-ozone hadoop-ozone/build-tools U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1435/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311817 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:39 Start Date: 12/Sep/19 23:39 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r323990902 ## File path: hadoop-ozone/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> + + + + + + + + + + + + + + + + + + + +
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311814=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311814 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:38 Start Date: 12/Sep/19 23:38 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r323990878 ## File path: hadoop-ozone/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> + + + + + + + + + + + + + + + + + + + +
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311815 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:38 Start Date: 12/Sep/19 23:38 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r323990885 ## File path: hadoop-ozone/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> + + + + + + + + + + + + + + + + + + + +
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311816 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:39 Start Date: 12/Sep/19 23:39 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r323990891 ## File path: hadoop-ozone/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + +http://www.w3.org/1999/XSL/Transform; version="1.0"> + + + + + + + + + + + + + + + + + + + +
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311813 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 23:38 Start Date: 12/Sep/19 23:38 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435#discussion_r323990870 ## File path: hadoop-ozone/build-tools/src/main/resources/checkstyle/checkstyle-noframes-sorted.xsl ## @@ -0,0 +1,189 @@ + > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2119) Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation
[ https://issues.apache.org/jira/browse/HDDS-2119?focusedWorklogId=311705=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311705 ] ASF GitHub Bot logged work on HDDS-2119: Author: ASF GitHub Bot Created on: 12/Sep/19 20:46 Start Date: 12/Sep/19 20:46 Worklog Time Spent: 10m Work Description: nandakumar131 commented on pull request #1435: HDDS-2119. Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. URL: https://github.com/apache/hadoop/pull/1435 After #1423 hdds/ozone no more relies on hadoop parent pom, so we have to use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle validation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311705) Remaining Estimate: 0h Time Spent: 10m > Use checkstyle.xml and suppressions.xml in hdds/ozone projects for checkstyle > validation > > > Key: HDDS-2119 > URL: https://issues.apache.org/jira/browse/HDDS-2119 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nanda kumar >Assignee: Nanda kumar >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > After HDDS-2106 hdds/ozone no more relies on hadoop parent pom, so we have to > use separate checkstyle.xml and suppressions.xml in hdds/ozone projects for > checkstyle validation. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
