[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=325737=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325737 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 09/Oct/19 14:43 Start Date: 09/Oct/19 14:43 Worklog Time Spent: 10m Work Description: adoroszlai commented on issue #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608#issuecomment-540033571 Thanks @anuengineer and @elek for reviewing, and @elek for committing it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325737) Time Spent: 1h 10m (was: 1h) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=325723=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325723 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 09/Oct/19 14:18 Start Date: 09/Oct/19 14:18 Worklog Time Spent: 10m Work Description: elek commented on pull request #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325723) Time Spent: 1h (was: 50m) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=324564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324564 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 07/Oct/19 19:15 Start Date: 07/Oct/19 19:15 Worklog Time Spent: 10m Work Description: anuengineer commented on pull request #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608#discussion_r332190504 ## File path: hadoop-ozone/dev-support/checks/_mvn_unit_report.sh ## @@ -45,6 +45,11 @@ grep -A1 'Crashed tests' "${REPORT_DIR}/output.log" \ | cut -f2- -d' ' \ | sort -u >> "${REPORT_DIR}/summary.txt" +## Check if Maven was killed +if grep -q 'Killed.* mvn .* test ' "${REPORT_DIR}/output.log"; then Review comment: So we are presuming that Killed will never be used by a test? :) I am fine with that. +1. LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324564) Time Spent: 50m (was: 40m) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=324524=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324524 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 07/Oct/19 17:34 Start Date: 07/Oct/19 17:34 Worklog Time Spent: 10m Work Description: adoroszlai commented on issue #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608#issuecomment-539122084 @elek please review (let me know if I should retest until we hit the case when integration test gets killed) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324524) Time Spent: 40m (was: 0.5h) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=324324=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324324 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 07/Oct/19 12:27 Start Date: 07/Oct/19 12:27 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608#issuecomment-538985920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 82 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | -1 | mvninstall | 51 | hadoop-hdds in trunk failed. | | -1 | mvninstall | 43 | hadoop-ozone in trunk failed. | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1006 | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 43 | hadoop-hdds in the patch failed. | | -1 | mvninstall | 44 | hadoop-ozone in the patch failed. | | +1 | mvnsite | 0 | the patch passed | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 862 | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | -1 | unit | 27 | hadoop-hdds in the patch failed. | | -1 | unit | 29 | hadoop-ozone in the patch failed. | | +1 | asflicense | 36 | The patch does not generate ASF License warnings. | | | | 2368 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1608 | | Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs | | uname | Linux 0d929d98df52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 7f332eb | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/branch-mvninstall-hadoop-hdds.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/branch-mvninstall-hadoop-ozone.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/patch-mvninstall-hadoop-hdds.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/patch-mvninstall-hadoop-ozone.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/testReport/ | | Max. process+thread count | 335 (vs. ulimit of 5500) | | modules | C: hadoop-ozone U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1608/1/console | | versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324324) Time Spent: 0.5h (was: 20m) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Sometimes integration
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=324291=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324291 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 07/Oct/19 11:47 Start Date: 07/Oct/19 11:47 Worklog Time Spent: 10m Work Description: adoroszlai commented on issue #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608#issuecomment-538970782 /label ozone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324291) Time Spent: 20m (was: 10m) > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2265) integration.sh may report false negative
[ https://issues.apache.org/jira/browse/HDDS-2265?focusedWorklogId=324290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324290 ] ASF GitHub Bot logged work on HDDS-2265: Author: ASF GitHub Bot Created on: 07/Oct/19 11:47 Start Date: 07/Oct/19 11:47 Worklog Time Spent: 10m Work Description: adoroszlai commented on pull request #1608: HDDS-2265. integration.sh may report false negative URL: https://github.com/apache/hadoop/pull/1608 ## What changes were proposed in this pull request? Check if Maven was killed during test run (observable in integration test runs). If so, mention it in `summary.txt`. Non-empty `summary.txt` is handled as "failure". https://issues.apache.org/jira/browse/HDDS-2265 ## How was this patch tested? Tested both positive and negative case: 1. successful run, `summary.txt` remains empty 2. manually killed `mvn` process, verified that `summary.txt` contains the expected line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324290) Remaining Estimate: 0h Time Spent: 10m > integration.sh may report false negative > > > Key: HDDS-2265 > URL: https://issues.apache.org/jira/browse/HDDS-2265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: build, test >Reporter: Attila Doroszlai >Assignee: Attila Doroszlai >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Sometimes integration test run gets killed, and {{integration.sh}} > incorrectly reports "success". Example: > {noformat:title=https://github.com/elek/ozone-ci-q4/tree/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/result} > success > {noformat} > {noformat:title=https://github.com/elek/ozone-ci-q4/blob/ae930d6f7f10c7d2aeaf1f2f21b18ada954ea444/pr/pr-hdds-2259-hlwmv/integration/output.log#L2457} > /workdir/hadoop-ozone/dev-support/checks/integration.sh: line 22: 369 > Killed mvn -B -fn test -f pom.ozone.xml -pl > :hadoop-ozone-integration-test,:hadoop-ozone-filesystem,:hadoop-ozone-tools > -Dtest=\!TestMiniChaosOzoneCluster "$@" > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org