On 2017-10-05 11:52:59, Harald Barth wrote:
>
> By looking at the code of send_diffs (ipropd_master.c:666) it looks to
> me that there somewhere at the beginning of that long function, before
> plowing through the log on the master, there should be something like
>
> if (current_version == 0 || s
> From what I can tell iprop has no way to differentiate between "I have no
> database, therefore I consider myself at version 0" and "I have a database, in
> sync with version 0".
I think (and hope) that a database is never at version 0 as it should
be created at version 1. So after the send_com
On October 6, 2017 5:56:22 AM EDT, Harald Barth wrote:
>
>Removing that without putting something else in place (and I would say
>not only s->version == 0 but even current_version == 0 should trigger
>a send_complete) was probably a bad idea.
It shouldn't be needed. First, a full dump is automati
On 2017-10-06 09:29:33, Jeffrey Hutzelman wrote:
>
> It shouldn't be needed. First, a full dump is automatically triggered
> if the master doesn't have enough log entries to bring the slave from
> its current version to the master version. so if a slave us at version
> 0, you either get a complete
Trungcating the log is not the same thing as resetting it, and preserves
the version number.
On Fri, Oct 06, 2017 at 09:29:33AM -0400, Jeffrey Hutzelman wrote:
> On October 6, 2017 5:56:22 AM EDT, Harald Barth wrote:
> It's also not necessary and in fact potentially harmful to check the
> master's version for 0. A real database can never be at version 0, so
> if you see that, something i
On Fri, Oct 06, 2017 at 04:48:20PM +0200, Patrik Lundin wrote:
> On 2017-10-06 09:29:33, Jeffrey Hutzelman wrote:
> > It shouldn't be needed. First, a full dump is automatically triggered
> > if the master doesn't have enough log entries to bring the slave from
> > its current version to the master
We're going to revisit the when-to-send_complete() logic. We've had one
case where a slave was stuck doing repeated send_completes.
It's also problematic that send_complete() is synchronous and
ipropd-master does not fork() and is not multi-threaded. We've seen a
case where one send_complete cau
