Re: [HelenOS-devel] Missing patch about Fix potential leak of memory

2016-07-08 Thread Jakub Jermář
On 07/06/2016 01:49 PM, Manuele Conti wrote: > I forgot to attach my patch file in my previous mail. Thanks, I applied this in mainline,2531. Jakub ___ HelenOS-devel mailing list HelenOS-devel@lists.modry.cz

Re: [HelenOS-devel] Fix potential leak of memory

2016-07-08 Thread Jakub Jermář
On 07/06/2016 01:05 PM, Manuele Conti wrote: > I found a potential leak of memory pointed to by 'entry' in task.c and i > fix it. Thanks, applied in mainline,2530. Jakub ___ HelenOS-devel mailing list HelenOS-devel@lists.modry.cz

Re: [HelenOS-devel] Fix Null pointer passed as an argument to a 'nonnull' parameter

2016-07-08 Thread Jakub Jermář
Hi Manuele, On 07/06/2016 12:52 PM, Manuele Conti wrote: > I found a bug in uspace/lib/drv/generic/remote_nic.c and I try to fix it. We have: uint8_t *data = NULL; if (max_length != 0) { data = malloc(max_length); if (data == NULL) {

Re: [HelenOS-devel] Fix leak kdio producer

2016-07-08 Thread Jakub Jermář
On 07/06/2016 10:37 AM, Manuele Conti wrote: > I found this bug in kio.c using cppcheck and I try to fix. Thanks, a nice catch. Partially applied in mainline,2529: I don't think the test for data==NULL is necessary and only clutters the code. Should data ever be NULL, let the caller be punished