Re: [HelenOS-devel] Ctrl+L Revision2

It's okay since it was my first patch. I would certainly try to give a better patch next time. Thanks, Ashish On Sat, Apr 1, 2017 at 4:27 PM, Jakub Jermář wrote: > On 04/01/2017 12:51 PM, Ashish Gahlot wrote: > > I have done it and included in the mail. > > Okay, now it looks

Re: [HelenOS-devel] Ctrl+L Revision2

On 04/01/2017 12:51 PM, Ashish Gahlot wrote: > I have done it and included in the mail. Okay, now it looks good. Note, however, that I am not going to merge this trivial patch as it brings only a very little benefit, if any, and has the issue of not moving the cursor. Cheers, Jakub

Re: [HelenOS-devel] Ctrl+L Revision2

On 04/01/2017 12:38 PM, Ashish Gahlot wrote: > To generate the patch I did *bzr diff tinput.c* and copied the output > from the terminal. Hm, that's probably where the tabs got changed to spaces. I'd recommend doing: bzr diff >patch.diff and then including patch.diff in the mail. Jakub

Re: [HelenOS-devel] Ctrl+L Revision2

Hello Jermar, To generate the patch I did *bzr diff tinput.c* and copied the output from the terminal. Thanks, Ashish On Sat, Apr 1, 2017 at 3:00 PM, Jakub Jermář wrote: > Hi Ashish, > > On 03/31/2017 12:41 PM, Ashish Gahlot wrote: > > This patch fixes the problem of

Re: [HelenOS-devel] Ctrl+L Revision2

Hi Ashish, On 03/31/2017 12:41 PM, Ashish Gahlot wrote: > This patch fixes the problem of moving the cursor to the beginning of > the screen by pressing Ctrl+L. > > > === modified file 'uspace/lib/clui/tinput.c' > --- uspace/lib/clui/tinput.c2015-10-20 10:08:15 + > +++

[HelenOS-devel] Ctrl+L Revision2

Hello HelenOS community, This patch fixes the problem of moving the cursor to the beginning of the screen by pressing Ctrl+L. === modified file 'uspace/lib/clui/tinput.c' --- uspace/lib/clui/tinput.c2015-10-20 10:08:15 + +++ uspace/lib/clui/tinput.c2017-03-31 10:39:07 + @@