Hi Supragya,

On 03/29/2017 07:08 PM, Supragya Raj wrote:
> this is patch for ptrdiff_t, rectified for every machine's arch.

This will probably be the last nit, but since ptrdiff_t is supposed to
be signed, can you make it signed also in boot (it already is signed in
kernel and uspace)?

And on a related note, can you change:

        if (sizeof(ptrdiff_t) == sizeof(uint32_t))

to

        if (sizeof(ptrdiff_t) == sizeof(int32_t))

to reflect the correct signedness in all three places?

Many thanks,
Jakub

_______________________________________________
HelenOS-devel mailing list
HelenOS-devel@lists.modry.cz
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to