Re: managing waiting patches

2022-09-05 Thread Ludovic Courtès
Hi,

Nicolas Graves  skribis:

> Is there a requirement to help with patch reviewing? I feel I can tackle
> python or rust packages unless they are weird, I need not to spend too
> much time on that, but if it's just advising new beginners (I'm myself
> a 9 month old Guix user but went cold turkey on my main machine, while
> my first patches were a nightmare, now I hope/believe they are quite
> clean) or trying to patch and build locally for <1h a day, with
> proper guidelines I might be able to help here.

Your help reviewing would be much welcome.

Currently there’s no strict “requirement” to help with patch review, but
the manual reads this (info "(guix) Commit Access"):

  One last thing: the project keeps moving forward because committers not
  only push their own awesome changes, but also offer some of their time
  _reviewing_ and pushing other people’s changes.  As a committer, you’re
  welcome to use your expertise and commit rights to help other
  contributors, too!

That hasn’t had the desired effect though—still too few reviewers among
the ~40 committers.  I’m not opposed to discussing whether to turn it
into a “requirement”.  A hot topic for those of us who’ll be in Paris
soonish!

Ludo’.



Re: Enterprise Guix Hosting?

2022-09-05 Thread Ludovic Courtès
Hi Phil,

Phil  skribis:

> Comments inline.  I'm also aiming to be at the Guix 10 Year thing in
> Paris - sadly only for the Friday, so happy to discuss this informally
> there too!

Looking forward to chatting there!

[...]

> Whilst I like Guix's own documentation, some developers did feedback to
> me that it was to complex for people who just wanted to get-on and use
> Guix, rather than setup, understand and maintain Guix.  So this is the
> area I ended-up documenting - "Guix Up-and-running for Python
> Developers". One day I'd like to publish it properly, but it's very much
> a WIP at the moment!

Publishing such a document (either standalone or as part of the
cookbook) would be great; it’d certainly be a gentle way to get started
for many developers out there.

> One advantage I did have is that I rewrote the CI/CD system
> to work around Guix, and the old system was showing it's age, so people
> were happy to trade Python venvs, for a better build and deployment 
> experience.

Yes, that too is a use case that we should document better (some years
ago I used Guix at work for CI, testing a piece of C++ code under a
variety of configurations—tedious to do without Guix.)

> We now have 5 developers working at least part of the time writing
> Guix packages, or tweaking small bits of the Guix core code (I keep
> meaning to make more of an effort to get our efforts back into Guix
> proper!).  As more developers slowly try-out more advanced stuff in Guix
> this number is growing, and most developers that invest the time end up
> liking Guix - so I think there's plenty of hope to grow it further!

Neat!

[...]

> 3 things which lowers the barrier to entry in my experience commercially
> would be:
>
> - Push button WSL support (I know this has some momentum eg
>   https://lists.gnu.org/archive/html/guix-patches/2022-08/msg00945.html).
>   At the moment I tend to use a custom image I made which is just WSL on
>   top of Ubuntu.  I have made it work with busybox, but it's not yet
>   robust enough to wheel out over the enterprise like this.
> - Perhaps a set of videos aimed directly at converting a vanilla Python
>   environment into one running in Guix.  Try to entice the communities
>   off their current tooling by making it as easy as possible to switch.
>   I even went as far as writing a requirements file to guix package
>   converter at work to help with this.
> - Excellent Javascript support would help.  I'm aware of some of the
>   difficulties this presents Guix, and am not a fan of npm, etc - but
>   it's so often used by developers I think not having support for it is
>   always going to be tricky to sell to a wider audience.

This is sorted in order of increasing difficulty (maybe exponentially
increasing, even :-)) but yes, these sound like good action items.

Thanks for your feedback!

Ludo’.



Re: [EXT] Re: Enterprise Guix Hosting?

2022-09-05 Thread Ludovic Courtès
Hello!

"Thompson, David"  skribis:

> On Wed, Aug 31, 2022 at 2:40 AM Ricardo Wurmus  wrote:
>>
>> Another thing that seems to be missing is a way to supervise and manage
>> running containers.  I use a shepherd instance for this with
>> container-specific actions like this:
>
> Hey that's a real nice starting point for a container management tool!
>  So maybe there should be a system service to manage containers and
> then a 'docker compose'-like tool for declaratively specifying
> containers and their network bridging configuration that is a client
> of the service?

Agreed!  We could turn Ricardo’s code into ‘container-guest-service’ or
something and have ‘containerized-operating-system’ add it
automatically.

Ludo’.



Re: a vector of colors

2022-09-05 Thread zimoun
Hi,

A bit late. :-)

On mar., 09 août 2022 at 20:58, jgart  wrote:

> Why was this defined as a vector instead of a list?
>
> (define %colors
>   ;; See colortbl.h in Graphviz.
>   #("red" "magenta" "blue" "cyan3" "darkseagreen"
> "peachpuff4" "darkviolet" "dimgrey" "darkgoldenrod"))

and you mean replace ’pop-color’ by,

--8<---cut here---start->8---
(define (pop-color hint)
  "Return a Graphviz color based on HINT, an arbitrary object."
  (let ((index (hash hint (length %colors
(list-ref %colors index)))
--8<---cut here---end--->8---

but I guess ’list-ref’ is slower than ’vector-ref’; as specified by the
documentation:

Vectors are sequences of Scheme objects. Unlike lists, the
length of a vector, once the vector is created, cannot be
changed. The advantage of vectors over lists is that the time
required to access one element of a vector given its position
(synonymous with index), a zero-origin number, is constant,
whereas lists have an access time linear to the position of the
accessed element in the list.

However, the difference is probably not visible here.


Cheers,
simon



Re: Tried to send a patch

2022-09-05 Thread Tobias Geerinckx-Rice

Adam,

Adam Kandur 写道:

I attached my previous message as a file. Thanks for your help.


Thanks, and please do try sending it to the list again.  It might 
have been a fluke.


пн, 5 сент. 2022 г. в 15:03, Tobias Geerinckx-Rice 
:

All I can say is it never hit Mailman.


That's actually not strictly true.  It never did so *from our 
perspective*, but it could have been silently swallowed.


Kind regards,

T G-R


signature.asc
Description: PGP signature


Re: Tried to send a patch

2022-09-05 Thread Adam Kandur
Hi Tobias!
I attached my previous message as a file. Thanks for your help.

пн, 5 сент. 2022 г. в 15:03, Tobias Geerinckx-Rice :
>
> Hi Adam,
>
> Adam Kandur 写道:
> > Two days ago I tried to send a patch to guix-patches. But my
> > message didn’t
> > appear in mail archive? Did I send it wrong?
>
> Probably?  It's hard to say otherwise without more information.
>
> The Guix project has no direct control over the mail server or
> access to its logs.  All I can say is it never hit Mailman.
>
> Assuming you used this same address, what was the subject?  Do you
> still have a copy of the message?  I could ask the GNU sysadmins
> to see if they can find traces of it.
>
> Kind regards,
>
> T G-R
--- Begin Message ---
* gnu/packages/golang.scm (go-github-com-goccy-go-json): New variable.
---
 gnu/packages/golang.scm | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 383d4d1..88bbd81 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2923,6 +2923,28 @@ (define-public go-github-com-burntsushi-toml
 is similar to Go's standard library @code{json} and @code{xml} package.")
 (license license:expat)))
 
+(define-public go-github-com-goccy-go-json
+  (package
+(name "go-github-com-goccy-go-json")
+(version "0.9.10")
+(source
+ (origin
+   (method git-fetch)
+   (uri (git-reference
+ (url "https://github.com/goccy/go-json;)
+ (commit (string-append "v" version
+   (file-name (git-file-name name version))
+   (sha256
+(base32 "1bg8p4c6r8r0kixdxv2m8xmdsmb1zl5sd8czswpccldjk3c358wp"
+(build-system go-build-system)
+(arguments
+ '(#:import-path "github.com/goccy/go-json"))
+(home-page "https://github.com/goccy/go-json;)
+(synopsis "JSON encoder/decoder in Go")
+(description
+ "Fast JSON encoder/decoder compatible with encoding/json for Go.")
+(license license:expat)))
+
 (define-public go-github-com-getsentry-raven-go
   (let ((commit "5c24d5110e0e198d9ae16f1f3465366085001d92")
 (revision "0"))
-- 
2.37.2

--- End Message ---


Re: Tried to send a patch

2022-09-05 Thread Tobias Geerinckx-Rice

Hi Adam,

Adam Kandur 写道:
Two days ago I tried to send a patch to guix-patches. But my 
message didn’t

appear in mail archive? Did I send it wrong?


Probably?  It's hard to say otherwise without more information.

The Guix project has no direct control over the mail server or 
access to its logs.  All I can say is it never hit Mailman.


Assuming you used this same address, what was the subject?  Do you 
still have a copy of the message?  I could ask the GNU sysadmins 
to see if they can find traces of it.


Kind regards,

T G-R


signature.asc
Description: PGP signature


Tried to send a patch

2022-09-05 Thread Adam Kandur
Hi guix!
Two days ago I tried to send a patch to guix-patches. But my message didn’t
appear in mail archive? Did I send it wrong?