Re: [Help-smalltalk] [PATCH v2 1/4] libgst: Fix comments

2017-12-01 Thread Holger Freyther
> On 30. Nov 2017, at 17:31, Lee Duhem wrote: > Hey! > /* Grows the allocated memory to SPACESIZE bytes, if it's not there > - already. > - the memory could not be allocated. Should be called after the > - sweep has occurred so that things are contiguous. Ensures that the > - OOP

Re: [Help-smalltalk] [PATCH v2 2/4] libgst: Miscellaneous improving to code style

2017-12-01 Thread Holger Freyther
> On 30. Nov 2017, at 17:31, Lee Duhem wrote: > Hi again! > @@ -2025,7 +2023,7 @@ _gst_to_wide_cstring (OOP stringOOP) > string = (gst_unicode_string) OOP_TO_OBJ (stringOOP); > len = oop_num_fields (stringOOP); > result = (wchar_t *) xmalloc (len + 1); > - if (sizeof (wchar_t) == 4) > +

Re: [Help-smalltalk] [PATCH v2 0/4] Some fixes to libgst

2017-12-01 Thread Lee Duhem
On Thu, Nov 30, 2017 at 6:17 PM, Holger Freyther wrote: > > > On 30. Nov 2017, at 18:11, Blake McBride wrote: > > > > Hey! > > > > Looks good. I hope your changes get integrated. > > > > Can you tell me what "This version 2 have no change since v1, only > rebased to top of master > > branch." m