On Fri, Dec 22, 2017 at 5:33 AM Steve Ebersole wrote:
>
> * When using ByteBuddy as the byte code provider, I still needed to have
>> Javassist around, as it's used in ClassFileArchiveEntryHandler. I
>> understand that eventually this should be using Jandex, but I'm wondering
>> whether we could
Sorry folks, responding to this thread out of order...
Steve, at first glance, this looks fine!
On 12/28/17 10:06 AM, Steve Ebersole wrote:
> After tweaking this, here is what I have...
>
> Manifest-Version: 1.0
> Created-By: 1.8.0_121 (Oracle Corporation)
> Main-Class: org.hibernate.Version
>
>
Actually I found the problem. Its actually not related to the manifest
change. The problem was a mismatch in the bundle group/module names for
JPA since we switched to the (now published) standard JPA API jar. Fixing
that fixed the failures. Sorry for the noise.
On Fri, Dec 29, 2017 at 10:35
Hey Steve, just to clarify, did this start failing directly after the
manifest change? Or are you saying it could be from other
dependency-related updates?
On 12/29/17 10:58 AM, Steve Ebersole wrote:
> Maybe this is similar to the problems we've had with the WildFly
> hibernate-orm-moudles st
Maybe this is similar to the problems we've had with the WildFly
hibernate-orm-moudles stuff - versions of karaf/aries/etc not yet
supporting EE8 techs (JPA 2.2, CDI 2.0, etc)?
On Thu, Dec 28, 2017 at 11:56 AM Steve Ebersole wrote:
> Brett, after making these changes the osgi tests now fail[1]
+1 for filtering out internal packages.
not a strong opinion on grouping
On 24 December 2017 at 14:23, Steve Ebersole wrote:
> Sure, but the question remains :P It just adds another one:
>
>
>1. Should internal packages be generated into the javadocs (individual
>and/or aggregated)?
>
