Re: [hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

On 07/09/2018 11:27 AM, Guillaume Smet wrote: > On Mon, Jul 9, 2018 at 5:12 PM Sanne Grinovero > wrote: > > No, but there are some tests which are specific to Javassist. > > > That's what I suspected. Let's run the full test suite with the new > version of Ja

Re: [hibernate-dev] AbstractStandardBasicType#getReplacement() prototype is incorrect since HHH-12054

Hi Gail, Don't waste your time on it for now. We had an interesting discussion with Yoann about it and I plan to revisit it. I'll ping you when it's done. Thanks. -- Guillaume On Thu, Jul 5, 2018 at 10:18 PM Gail Badner wrote: > Hi Guillaume, > > Thanks for reminding me about this in my PR

Re: [hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

On Mon, Jul 9, 2018 at 5:12 PM Sanne Grinovero wrote: > No, but there are some tests which are specific to Javassist. > That's what I suspected. Let's run the full test suite with the new version of Javassist then. I prefer to be on the safe side, especially because I'm not sure all the bugs in

Re: [hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

On Mon, 9 Jul 2018 at 16:09, Guillaume Smet wrote: > > On Mon, Jul 9, 2018 at 4:56 PM Sanne Grinovero wrote: >> >> send a PR, the bots will trigger test runs at least for Java 8. > > > Do we run all the tests with Javassist now that Bytebuddy is the default? No, but there are some tests which ar

Re: [hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

On Mon, Jul 9, 2018 at 4:56 PM Sanne Grinovero wrote: > send a PR, the bots will trigger test runs at least for Java 8. > Do we run all the tests with Javassist now that Bytebuddy is the default? -- Guillaume ___ hibernate-dev mailing list hibernate-

Re: [hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

Hi Scott, send a PR, the bots will trigger test runs at least for Java 8. For proper JDK11 testing that will have to wait as other things aren't working yet, but if the Javassist update works flawlessly on Java 8 there is no reason to not update this point already. Thanks, Sanne On Mon, 9 Jul

[hibernate-dev] Javassist version alignment for Hibernate ORM 5.3 + WildFly 14...

We would like to update WildFly (14) to Javassist 3.23.1, has anyone tried using Javassist 3.23.1 with Hibernate ORM 5.3? I'd like to know that we at least can pass the Javassist tests with the ORM testsuite, preferably on JDK11 (since that is why we want to upgrade Javassist on WildFly). Tha