Sounds good to me! :)
On Fri, Jan 11, 2019 at 8:19 AM Sanne Grinovero wrote:
> On Fri, 11 Jan 2019 at 14:00, Steve Ebersole wrote:
> >
> > Guillaume - I added a general start-a-discussion comment to the PR.
> Hopefully anyone with an opinion on that can chime in there. Beyond that,
> +1
> >
>
On Fri, 11 Jan 2019 at 14:00, Steve Ebersole wrote:
>
> Guillaume - I added a general start-a-discussion comment to the PR.
> Hopefully anyone with an opinion on that can chime in there. Beyond that, +1
>
>
> Sanne - ok, I see. You are not expecting users to have to deal with
>
Guillaume - I added a general start-a-discussion comment to the PR.
Hopefully anyone with an opinion on that can chime in there. Beyond
that, +1
Sanne - ok, I see. You are not expecting users to have to deal with
wrapping/scrolling because you limit the presented information to an
arbitrary
On Fri, 11 Jan 2019 at 09:53, Guillaume Smet wrote:
>
> So what I suggest: if you disagree on a change, just comment on the specific
> line of the PR and I'll revert.
>
> I plan to merge that on Tuesday.
I like it. Not merging it yet to get Steve a chance to comment too.
A minor nitpick: not
On Thu, 10 Jan 2019 at 16:39, Steve Ebersole wrote:
>
>
>
> On Thu, Jan 10, 2019 at 10:15 AM Sanne Grinovero wrote:
>>
>> On Thu, 10 Jan 2019 at 01:44, Steve Ebersole wrote:
>> >
>> > I disagree that logging a single message is a better solution because that
>> > probably ends up wrapping
So what I suggest: if you disagree on a change, just comment on the
specific line of the PR and I'll revert.
I plan to merge that on Tuesday.
On Fri, Jan 11, 2019 at 10:24 AM Guillaume Smet
wrote:
> In meeting all day so making progress on dumb stuff.
>
> Here is a very conservative PR on
In meeting all day so making progress on dumb stuff.
Here is a very conservative PR on which I hope we could agree on quickly:
https://github.com/hibernate/hibernate-orm/pull/2728
--
Guillaume
On Thu, Jan 10, 2019 at 5:38 PM Steve Ebersole wrote:
>
>
> On Thu, Jan 10, 2019 at 10:15 AM Sanne
I know I reproduced it locally earlier this week.
Can't get back to it today but I can push a test case next week.
IMHO, it's very low priority.
On Fri, Jan 11, 2019 at 3:04 AM Steve Ebersole wrote:
> Trying to make sure I understand.. so the report is just wrong? Or is
> there some
