Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?

2019-08-07 Thread Sanne Grinovero
Cool, thanks! I think we're good now, we'll just go with it. Worst case it's easy to revert. On Wed, 7 Aug 2019 at 14:44, Scott Marlow wrote: > > Hi Sanne, > > WildFly doesn't reference StatisticsImpl, WildFly does use Statistics. > > Scott ___

Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?

2019-08-07 Thread Steve Ebersole
I do not remember the history for it. +1 for removing that no-arg form. On Wed, Aug 7, 2019 at 4:08 AM Sanne Grinovero wrote: > Hi all, > > while working on HHH-13527 I noticed that there's quite some > complexity in StatisticsImpl to deal with the fact that the final > field `sessionFactory`

Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?

2019-08-07 Thread Sanne Grinovero
Thanks, I applied the cleanup. If it was a mistake, I guess I'll hear about it :) On Wed, 7 Aug 2019 at 12:50, Yoann Rodiere wrote: > > Hi, > > I had a quick look at Hibernate Search's source code, and couldn't find any > use of this class. > So +1 for me. > > > Yoann Rodière > Hibernate NoORM

Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?

2019-08-07 Thread Yoann Rodiere
Hi, I had a quick look at Hibernate Search's source code, and couldn't find any use of this class. So +1 for me. Yoann Rodière Hibernate NoORM Team yo...@hibernate.org On Wed, 7 Aug 2019 at 11:08, Sanne Grinovero wrote: > Hi all, > > while working on HHH-13527 I noticed that there's quite