Re: [hibernate-dev] Batch indexing API

2009-07-07 Thread Emmanuel Bernard
ok, go ahead what ever that means :). On Jul 7, 2009, at 10:49, Sanne Grinovero wrote: inline: 2009/7/5 Emmanuel Bernard : cacheMode //when would you need something different than Ignore? Also, I'd rather get CacheMode be a Search class to keep the independance wrt Hibernate Core Depen

Re: [hibernate-dev] Batch indexing API

2009-07-07 Thread Sanne Grinovero
inline: 2009/7/5 Emmanuel Bernard : > >>> cacheMode //when would you need something different than Ignore? Also, >>> I'd >>> rather get CacheMode be a Search class to keep the independance wrt >>> Hibernate Core >> >> Depending on the model it might be much faster using cache when the >> indexed e

Re: [hibernate-dev] Batch indexing API

2009-07-05 Thread Emmanuel Bernard
cacheMode //when would you need something different than Ignore? Also, I'd rather get CacheMode be a Search class to keep the independance wrt Hibernate Core Depending on the model it might be much faster using cache when the indexed entity is having a @manytoo...@indexedembedded relation to

Re: [hibernate-dev] Batch indexing API

2009-07-05 Thread Sanne Grinovero
thanks, answering inline: 2009/7/3 Emmanuel Bernard : > Overall I think it's good. > some proposals (when followed by a ? my feeling is that the original name is > as good or better) > Generally, I've inversed names to make the most important word first. > > Indexer => MassIndexer fine > objectLo

Re: [hibernate-dev] Batch indexing API

2009-07-05 Thread Emmanuel Bernard
Overall I think it's good. some proposals (when followed by a ? my feeling is that the original name is as good or better) Generally, I've inversed names to make the most important word first. Indexer => MassIndexer objectLoadingThreads => threadsToLoadObjects objectLoadingBatchSize => batchSi

[hibernate-dev] Batch indexing API

2009-06-30 Thread Sanne Grinovero
Hello, I need some comments about the batch indexing API, so that I can stabilize it and write the documentation; I might even blog about it :-) Here is the current sketch: http://fisheye.jboss.org/browse/Hibernate/search/trunk/src/main/java/org/hibernate/search/Indexer.java?r=16967 Emmanuel I re