Re: [hibernate-dev] Batch version data support in Dialect

2016-02-10 Thread Vlad Mihalcea
Hi, The user can override these settings, that's actually how the test failed for that user (although I wonder why he passed that environment variable to the test anyway). Thanks for clarifying the design decision for controlling some dialect-based properties. Vlad On Wed, Feb 10, 2016 at 5:29

Re: [hibernate-dev] Batch version data support in Dialect

2016-02-10 Thread Steve Ebersole
Dialect#defaultProperties is a broken concept IMO. It was an attempt to avoid an explosion of methods such as the one you propose. I personally agree that the specific methods are better. However, all that said.. I do not believe what you say is accurate. At least not looking at the code. In S

[hibernate-dev] Batch version data support in Dialect

2016-02-08 Thread Vlad Mihalcea
Hi, While browsing the PRs on GitHub, I stumbled on this issue: https://hibernate.atlassian.net/browse/HHH-10290 In the current implementation, the hibernate.jdbc.batch_versioned_data property is set to true and we override it at Dialect-level as follows: public Oracle12cDialect() { super();