Re: [hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Steve Ebersole
Great, thanks! On Wed, Mar 30, 2016 at 1:39 PM Vlad Mihalcea wrote: > Sure, I'll add a new one containing the email conclusions and a link to > HHH-10014 and commit it tomorrow. > > Vlad > > On Wed, Mar 30, 2016 at 9:23 PM, Steve Ebersole > wrote: > >> No. Never do work under a closed Jira. T

Re: [hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Vlad Mihalcea
Sure, I'll add a new one containing the email conclusions and a link to HHH-10014 and commit it tomorrow. Vlad On Wed, Mar 30, 2016 at 9:23 PM, Steve Ebersole wrote: > No. Never do work under a closed Jira. That's essentially revising > history. Create a new Jira. You can link that new one

Re: [hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Steve Ebersole
No. Never do work under a closed Jira. That's essentially revising history. Create a new Jira. You can link that new one to HHH-10014. On Wed, Mar 30, 2016 at 1:12 PM Vlad Mihalcea wrote: > Hi Steve, > > Should I add those two fixes under the > https://hibernate.atlassian.net/browse/HHH-1001

Re: [hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Vlad Mihalcea
Hi Steve, Should I add those two fixes under the https://hibernate.atlassian.net/browse/HHH-10014 issue? I can do it tomorrow. Vlad On Wed, Mar 30, 2016 at 5:40 PM, Steve Ebersole wrote: > The code is wrong in > the GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS case; the java doc > is co

Re: [hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Steve Ebersole
The code is wrong in the GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS case; the java doc is correct. By default we should not be skipping columnDefinitions while applying global-quoting to be sec compliant. In the second case, its the opposite... the javadoc is wrong. Keyword-quoting shoul

[hibernate-dev] Configuration default values inconsitencies

2016-03-30 Thread Vlad Mihalcea
Hi, I found an inconsistency in JavaDocs and code: 1. The GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS JavaDocs says "JPA states that column-definitions are subject to global quoting, so by default this setting is {@code false} for JPA compliance. Set to {@code true} to avoid column-defin