Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 12:29, Steve Ebersole wrote: > > For me its ok. We end up handling each of these specifically anyway nowadays. Thanks! I'll merge then. > > On Thu, Oct 18, 2018 at 6:16 AM Sanne Grinovero wrote: >> >> Since this is a rather un-interesting topic I guess I'll just proceed

Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Steve Ebersole
For me its ok. We end up handling each of these specifically anyway nowadays. On Thu, Oct 18, 2018 at 6:16 AM Sanne Grinovero wrote: > Since this is a rather un-interesting topic I guess I'll just proceed with > a PR: > - https://github.com/hibernate/hibernate-orm/pull/2594 > > It can easily

Re: [hibernate-dev] Deprecating Environment#verifyProperties

2018-10-18 Thread Sanne Grinovero
Since this is a rather un-interesting topic I guess I'll just proceed with a PR: - https://github.com/hibernate/hibernate-orm/pull/2594 It can easily be reverted in case someone badly wants it back. On Wed, 17 Oct 2018 at 16:26, Sanne Grinovero wrote: > > Currently this method is used but not

[hibernate-dev] Deprecating Environment#verifyProperties

2018-10-17 Thread Sanne Grinovero
Currently this method is used but not doing much at all, as maps OBSOLETE_PROPERTIES and RENAMED_PROPERTIES are constant and empty. I'm wondering if this is because it's just a coincidence at this point in time we have nothing registered in those maps, or if this strategy is just no longer the