Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-22 Thread Sanne Grinovero
On Mon, 22 Oct 2018 at 09:53, Guillaume Smet wrote: > > On Sun, Oct 21, 2018 at 9:48 PM Sanne Grinovero wrote: >> >> > I think it goes without saying but we still need to have ORM working >> > without enhancement, considering how many bugs we have related to enhanced >> > classes. >> >> I

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-22 Thread Guillaume Smet
On Sun, Oct 21, 2018 at 9:48 PM Sanne Grinovero wrote: > > I think it goes without saying but we still need to have ORM working > without enhancement, considering how many bugs we have related to enhanced > classes. > > I didn't understand thist last sentence. Could you please clarify? > Even

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-21 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 14:02, Guillaume Smet wrote: > > Hi, > > On Thu, Oct 18, 2018 at 1:33 PM Sanne Grinovero wrote: >> >> > Regarding "BasicProxyFactory", Guillaume and I had to fight with this >> > think a few weeks ago, I think. If I remember correctly, it's used in >> > particular to

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Steve Ebersole
We need to keep it working without enhancement, bugs or not On Thu, Oct 18, 2018, 8:27 AM Guillaume Smet wrote: > Hi, > > On Thu, Oct 18, 2018 at 1:33 PM Sanne Grinovero > wrote: > > > > Regarding "BasicProxyFactory", Guillaume and I had to fight with this > > think a few weeks ago, I think.

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Guillaume Smet
Hi, On Thu, Oct 18, 2018 at 1:33 PM Sanne Grinovero wrote: > > Regarding "BasicProxyFactory", Guillaume and I had to fight with this > think a few weeks ago, I think. If I remember correctly, it's used in > particular to instantiate abstract classes (!) during bootstrap. It seems > to be needed

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Sanne Grinovero
On Thu, 18 Oct 2018 at 07:39, Yoann Rodiere wrote: > > Can't say if it's a good or bad idea, but if you don't document it in the > user guide, please at least document how dangerous it is and why it can be > useful in the source code where the "none" option appears. I expect some > users will

Re: [hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-18 Thread Yoann Rodiere
Can't say if it's a good or bad idea, but if you don't document it in the user guide, please at least document how dangerous it is and why it can be useful in the source code where the "none" option appears. I expect some users will find it while debugging, try it out to solve their problems or

[hibernate-dev] Introducing a "none" BytecodeProvider

2018-10-17 Thread Sanne Grinovero
After some experimentation I figured out that the BytecodeProvider is not really necessary, if you are happy to use the tools we have to enhance the entities upfront. In some environments such as on GraalVM I need to pre-enhance the entities (need as in "not optional"), but some further things