Re: [hibernate-dev] Property using field access and has final getter/setter method

2020-03-06 Thread Gail Badner
Here's the PR: https://github.com/hibernate/hibernate-orm/pull/3286 On Thu, Mar 5, 2020 at 10:21 PM Gail Badner wrote: > I created https://hibernate.atlassian.net/browse/HHH-13891. > > IIUC, a ProxyFactory should not be created if any ID, version, or property > method getter/setter is final. >

Re: [hibernate-dev] Property using field access and has final getter/setter method

2020-03-05 Thread Gail Badner
I created https://hibernate.atlassian.net/browse/HHH-13891. IIUC, a ProxyFactory should not be created if any ID, version, or property method getter/setter is final. I'm working on a PR. Thanks, Gail On Thu, Mar 5, 2020 at 7:56 AM Steve Ebersole wrote: > If any getters or setters are final

Re: [hibernate-dev] Property using field access and has final getter/setter method

2020-03-05 Thread Steve Ebersole
If any getters or setters are final then the ProxyFactory cannot be used and imo should not get built, especially moving forward as we could use bytecode-based proxies On Wed, Mar 4, 2020 at 2:11 PM Gail Badner wrote: > This commit [1] for HHH-11838 [2] causes an error to get logged by >

[hibernate-dev] Property using field access and has final getter/setter method

2020-03-04 Thread Gail Badner
This commit [1] for HHH-11838 [2] causes an error to get logged by ProxyFactoryHelper#validateProxyability [3] for a property that uses field access and has a corresponding final getter/setter method. The logged error does not cause any failure, and the ByteBuddyProxyFactory gets built. Should