Hi Fabio,
yes good point. Infinispan has been using our feature packs as well, but
they are in a similar situation and will have to change strategy.
Even if others will need them, we don't have much choice: the existing
feature packs won't work with the newer WildFly versions. So we'll keep
Hello,
I take advantage of the topic to say that there is an `integrationtests`
module in Infinispan too using feature packs, which are usings in turn the
feature packs of the Hibernate Search 5.
I have to ask the ISPN guys on Zulip about that, maybe they have already
planned to remove such
We have a PR for this now, if someone would like to have a look:
- https://github.com/hibernate/hibernate-orm/pull/3347
One thing to note, is that it also removes all Arquillian based tests:
we had some which were testing more than just the basics of our
feature pack; although most had been
> Any specific reason you say that Yoann?
No, I was just thinking that moving to Jarakarta JPA and Jakarta CDI had a
high chance of breaking OSGi tests, unless the Jakarta artifacts properly
support OSGi.
But it was just a hunch; if it works, I don't have anything against keeping
it.
Yoann
I do not plan on dropping hibernate-osgi. Its there; it works. Any
specific reason you say that Yoann?
Brett is the only one to do anything with that "tutorial". Though as time
went on its focus was more a way to find problems when the paxexam tests
failed - they almost always give useless
Agreed, I'll remove it. Thanks Steve and Yoann!
I'll remove them from 5.5 soon, you can then merge the removal in 6.0
or do it differently if that's easier.
This is the JIRA:
- https://hibernate.atlassian.net/browse/HHH-13952
Regarding OSGi (which Yoann raised): I agree we shouldn't spend
Considering the changes in WildFly, I also think we should just drop
hibernate-orm-modules.
For 6.0 I will definitely do this. I also think removing it is good for
5.5.
Not sure it is even worth the hassle for earlier releases however.
On Wed, Apr 15, 2020 at 5:03 PM Sanne Grinovero wrote:
Hello,
As far as I know, the feature packs are here for two reasons:
1. To test compatibility of ORM with WildFly while still developing it.
2. To provide non-official (wrt. WildFly) ways to upgrade ORM to the latest
version within WildFly.
#1 does not look *that* important for 5.5, since we
As we're working to upgrade to Jakarta EE 9, our feature packs for
Wildfly are not going to be functional for a while at least.
Not only do we have to upgrade to JPA 3, but we also need to upgrade
our integrations with a different Validator, a different CDI - none of
these are provided by WildFly
