Re: [hibernate-dev] on broken usage of logger

2011-11-24 Thread Hardy Ferentschik
On Wed, 23 Nov 2011 17:15:50 +0100, David M. Lloyd wrote: > The solution is really easy guys: > > log.debugf("The thing I want to log is %s", thing); > or > log.debug(thing) > > In addition, as you have noticed, it is better to not use the formatting > variants if you aren't actually formatti

Re: [hibernate-dev] on broken usage of logger

2011-11-23 Thread David M. Lloyd
The solution is really easy guys: log.debugf("The thing I want to log is %s", thing); or log.debug(thing) In addition, as you have noticed, it is better to not use the formatting variants if you aren't actually formatting any strings (it doesn't make a difference if the message isn't logged, bu

Re: [hibernate-dev] on broken usage of logger

2011-11-23 Thread Hardy Ferentschik
Hi, this revives my email from Friday (http://lists.jboss.org/pipermail/hibernate-dev/2011-November/007307.html) where I noticed this problem as well. Generally speaking Sanne is of course right and the right logging method should be used, but does the logging framework really have to propaga

Re: [hibernate-dev] on broken usage of logger

2011-11-23 Thread Christian Bauer
On Nov 23, 2011, at 11:34 , Sanne Grinovero wrote: > log.debugf vs log.debug > log.tracef vs log.trace This also seems to be the difference between these messages with JUL: [main] TRACE - 11:27:51,428 - org.hibernate.loader.Loader: org.hibernate.internal.CoreMessageLog

[hibernate-dev] on broken usage of logger

2011-11-23 Thread Sanne Grinovero
Hi all, I'm having a chat with Hardy about how we used the Logger in some cases, and it turns out there's some confusion about log.debugf vs log.debug log.tracef vs log.trace So the "F" variant is needed when we want to format a message, in this case we should make sure the number o