Re: [hibernate-dev] HHH-12125 - @GeneratedValue & 5.3

2017-11-27 Thread Chris Cranford
Sounds reasonable to me. On 11/25/2017 12:45 PM, Steve Ebersole wrote: > I just updated the text for the Jira[1]. > > Specifically, in the section on SEQUENCE and TABLE, at the moment I have > kept the legacy behavior of using "hibernate_sequence" as the name of the > table/sequence - users must

Re: [hibernate-dev] HHH-12125 - @GeneratedValue & 5.3

2017-11-25 Thread Steve Ebersole
I just updated the text for the Jira[1]. Specifically, in the section on SEQUENCE and TABLE, at the moment I have kept the legacy behavior of using "hibernate_sequence" as the name of the table/sequence - users must opt-in to the behavior of using `@GeneratedValue#generator` as the sequence/table

Re: [hibernate-dev] HHH-12125 - @GeneratedValue & 5.3

2017-11-25 Thread Vlad Mihalcea
That's a great idea. I stumbled on this issue many times, and it's very good to simplify the mapping as you suggested. +1 Vlad On Sat, Nov 25, 2017 at 6:18 PM, Steve Ebersole wrote: > The background is all in the Jira, but the crux is this... it is better to > allow a

Re: [hibernate-dev] HHH-12125 - @GeneratedValue & 5.3

2017-11-25 Thread Steve Ebersole
Actually I just realized I was a little smarter than this back then :D `IdGeneratorStrategyInterpreter#determineGeneratorName` is actually passed the GenerationType and a "parameter object". I can add access to the generator name to the parameter object. On Sat, Nov 25, 2017 at 10:18 AM Steve