Re: [hibernate-dev] Batch version data support in Dialect

2016-02-10 Thread Steve Ebersole
Dialect#defaultProperties is a broken concept IMO. It was an attempt to avoid an explosion of methods such as the one you propose. I personally agree that the specific methods are better. However, all that said.. I do not believe what you say is accurate. At least not looking at the code. In S

Re: [hibernate-dev] Batch version data support in Dialect

2016-02-10 Thread Vlad Mihalcea
Hi, The user can override these settings, that's actually how the test failed for that user (although I wonder why he passed that environment variable to the test anyway). Thanks for clarifying the design decision for controlling some dialect-based properties. Vlad On Wed, Feb 10, 2016 at 5:29

[hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
The release build is done. Push away! On Wed, Feb 10, 2016 at 11:14 AM Steve Ebersole wrote: > > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Sanne Grinovero
Congratulations!! On 10 February 2016 at 18:16, Steve Ebersole wrote: > The release build is done. Push away! > > > On Wed, Feb 10, 2016 at 11:14 AM Steve Ebersole wrote: > >> >> > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > htt

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Vlad Mihalcea
Congrats! I checked the docs but the User Guide is still the old one: http://docs.jboss.org/hibernate/orm/5.1/userGuide/en-US/html_single/ Should we make the switch in a future release? On Wed, Feb 10, 2016 at 8:20 PM, Sanne Grinovero wrote: > Congratulations!! > > On 10 February 2016 at 18:16

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
I thought you had updated the documentation build to build this? On Wed, Feb 10, 2016 at 12:31 PM Vlad Mihalcea wrote: > Congrats! I checked the docs but the User Guide is still the old one: > > http://docs.jboss.org/hibernate/orm/5.1/userGuide/en-US/html_single/ > > Should we make the switch i

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Vlad Mihalcea
Hi, I haven't changed the current build process. I'll have to investigate where to make the change. On Wed, Feb 10, 2016 at 9:01 PM, Steve Ebersole wrote: > I thought you had updated the documentation build to build this? > > > On Wed, Feb 10, 2016 at 12:31 PM Vlad Mihalcea > wrote: > >> Congr

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
I need to deal with the new link ontology we decided on for the doc server anyway On Wed, Feb 10, 2016 at 1:08 PM Steve Ebersole wrote: > no, I'll do it > > On Wed, Feb 10, 2016 at 1:05 PM Vlad Mihalcea > wrote: > >> Hi, >> >> I haven't changed the current build process. I'll have to investigat

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
no, I'll do it On Wed, Feb 10, 2016 at 1:05 PM Vlad Mihalcea wrote: > Hi, > > I haven't changed the current build process. I'll have to investigate > where to make the change. > > On Wed, Feb 10, 2016 at 9:01 PM, Steve Ebersole > wrote: > >> I thought you had updated the documentation build to

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
I fixed the symlinks on the doc server as follows: 1. created a `/orm/current` symlink pointing to `/orm/5.1` 2. updated `/stable/orm` to point to `/orm/current` 3. updated `/stable/core` to point to `/stable/orm` (I could not remember what it pointed to previously). So as of right n

[hibernate-dev] ORM 5.1 feature release

2016-02-10 Thread Steve Ebersole
ORM 5.1 has just been released. See details @ http://in.relation.to/2016/02/10/hibernate-orm-510-final-release/ ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] Version-specific data on hibernate.org (was Re: Starting 5.1.0 release)

2016-02-10 Thread Steve Ebersole
A related concern is a discussion I started before in regards to version specific information on hibernate.org Did we ever come to any conclusion about how (if) we were going to handle that? On Wed, Feb 10, 2016 at 1:40 PM Steve Ebersole wrote: > I fixed the symlinks on the doc server as follo

Re: [hibernate-dev] Version-specific data on hibernate.org (was Re: Starting 5.1.0 release)

2016-02-10 Thread Vlad Mihalcea
Hi Steve, I created this PR for switching to the new User Guide https://github.com/hibernate/hibernate-orm/pull/1260 The release build already copies from ascidocs folder so I think it's fine. On Wed, Feb 10, 2016 at 10:06 PM, Steve Ebersole wrote: > A related concern is a discussion I starte

Re: [hibernate-dev] Starting 5.1.0 release

2016-02-10 Thread Steve Ebersole
Maybe the better option is to have the build simply upload to the versioned docs dir (orm/5.0, orm/5.1, etc) and to manage the `current` symlink by hand. That really only needs to change when the next feature release becomes stable. On Wed, Feb 10, 2016 at 1:40 PM Steve Ebersole wrote: > I fix

[hibernate-dev] PropertyFactory and invocation of PropertyAccessStrategyResolver

2016-02-10 Thread Gunnar Morling
Hey, In ORM's PropertyFactory#getGetter() line 317 I see that mappingProperty.getClass() is passed to resolvePropertyAccessStrategy() [1]. I.e. the type org.hibernate.mapping.Property or similar will be passed here. Is this actually correct? It seems mappingProperty.getPersistentClass().getMapped

Re: [hibernate-dev] Version-specific data on hibernate.org (was Re: Starting 5.1.0 release)

2016-02-10 Thread Emmanuel Bernard
Nope. I don't remember a how we could discussion that explored the subject deeply. > On 10 févr. 2016, at 21:06, Steve Ebersole wrote: > > A related concern is a discussion I started before in regards to version > specific information on hibernate.org > > Did we ever come to any conclusion ab