[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-09 Thread Mark Rotteveel
Looking at this again, I wonder if `Dialect.supportsValuesList()` would be the right check. A lot of dialects return false for this (except CockroachDB, DB2, PostgreSQL and SQL Server), but - I assume - they don't fail this test. I guess those dialects support the values list in insert, but no

[hibernate-dev] Re: Dialect.supportsValuesList() ignored for InsertUpdateTests.testInsertValues

2021-03-09 Thread Christian Beikov
Hey Mark, please consider the value that `Dialect.supportsValuesList()` returns as irrelevant. It doesn't return the correct value for all databases as you figured. Apart from that, we are trying to get rid of such functions in Dialect and integrate this into the SqlAstTranslator as much as p