Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-17 Thread Steve Ebersole
Not really sure what "better" names you have in mind, but to me only one of these 2 is really an identifier. This new method is more a niche value to me. So not sure why you want to rename the original. On Fri, Apr 17, 2020 at 3:36 PM Sanne Grinovero wrote: > On Thu, 16 Apr 2020 at 01:06,

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-17 Thread Sanne Grinovero
On Thu, 16 Apr 2020 at 01:06, Gail Badner wrote: > > Hi Galder, > > Thanks for the response. I agree this would be a good change for H6. I'm > happy to hear that this is on someone's radar for Infinispan. > > Sanne, regarding: > > I'd say if you clearly mark the old method deprecated (or even

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-15 Thread Gail Badner
Hi Galder, Thanks for the response. I agree this would be a good change for H6. I'm happy to hear that this is on someone's radar for Infinispan. Sanne, regarding: > I'd say if you clearly mark the old method deprecated (or even remove it?) it will be guaranteed we don't forget about this

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-15 Thread Sanne Grinovero
On Wed, 15 Apr 2020 at 02:16, Gail Badner wrote: > > FWIW, there's no point in fixing HHH-13916 unless we hear that Infinispan is > going to use the fix. I suppose we can expect that that will eventually happen - I just don't know when and were to best make a note of such a need? I'd say if you

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-14 Thread Gail Badner
FWIW, there's no point in fixing HHH-13916 unless we hear that Infinispan is going to use the fix. Radim/Galder, WDYT? Thanks, Gail On Tue, Apr 14, 2020 at 3:25 PM Gail Badner wrote: > Hi Sanne, > > I've reworked HHH-13916 to > use this

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-14 Thread Gail Badner
Hi Sanne, I've reworked HHH-13916 to use this alternative, and set the fix version to 6-wishlist. Regards, Gail On Tue, Apr 14, 2020 at 1:23 AM Sanne Grinovero wrote: > Hi Gail, > > I would go ahead with this improvement for ORM 6 and avoid

Re: [hibernate-dev] HHH-13916 / WFLY-13259

2020-04-14 Thread Sanne Grinovero
Hi Gail, I would go ahead with this improvement for ORM 6 and avoid spending your precious time on a v5 improvement - especially if it's going to require coordination with both the Infinispan and WildFly teams. Thanks On Fri, 10 Apr 2020 at 00:56, Gail Badner wrote: > > I've been looking into

[hibernate-dev] HHH-13916 / WFLY-13259

2020-04-09 Thread Gail Badner
I've been looking into how to fix this issue: https://hibernate.atlassian.net/browse/HHH-13916 https://issues.redhat.com/browse/WFLY-13259 The crux of the matter is when Hibernate calls CacheHelper.fromSharedCache( session, cacheKey, cachAccess ), and the entity is not found in the cache,