Re: [Hibernate] sessionfactoryimpl.close()

2005-09-27 Thread Max Rydahl Andersen
uld be perfectly reasonable to clear the internal collections. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Max Rydahl Andersen Sent: Monday, 26 September 2005 3:20 PM To: Emmanuel Bernard Cc: Hibernate development Subject: Re: [Hibernate] sessionfactoryimpl.clos

RE: [Hibernate] sessionfactoryimpl.close()

2005-09-27 Thread Gavin King
They are wrapped in UnmodifiableBlahBlah -Original Message- From: Steve Ebersole Sent: Tuesday, 27 September 2005 3:49 PM To: Max Andersen; Gavin King; Emmanuel Bernard Cc: Hibernate development Subject: RE: [Hibernate] sessionfactoryimpl.close() Why? You can call clear() on

RE: [Hibernate] sessionfactoryimpl.close()

2005-09-27 Thread Steve Ebersole
Bernard Cc: Hibernate development Subject: Re: [Hibernate] sessionfactoryimpl.close() Hi, We tried to do this but it requires us to un-final stuff and that is not worth it. Instead I added a comment to sf.close() about the importance of actually not keeping a reference to the sf when it is not want

Re: [Hibernate] sessionfactoryimpl.close()

2005-09-27 Thread Max Rydahl Andersen
collections. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Max Rydahl Andersen Sent: Monday, 26 September 2005 3:20 PM To: Emmanuel Bernard Cc: Hibernate development Subject: Re: [Hibernate] sessionfactoryimpl.close() OTOH, this will consume some extra

RE: [Hibernate] sessionfactoryimpl.close()

2005-09-27 Thread Gavin King
I think it would be perfectly reasonable to clear the internal collections. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Max Rydahl Andersen Sent: Monday, 26 September 2005 3:20 PM To: Emmanuel Bernard Cc: Hibernate development Subject: Re: [Hibernate

Re: [Hibernate] sessionfactoryimpl.close()

2005-09-26 Thread Emmanuel Bernard
My point is that we should fix the user in this case, not our code ;-) Less code, less maintenance. It's like the session open check in a finalize. Was a good idea in theory, but with bad impacts in practice. Max Rydahl Andersen wrote: OTOH, this will consume some extra CPU time for nothing si

Re: [Hibernate] sessionfactoryimpl.close()

2005-09-26 Thread Max Rydahl Andersen
OTOH, this will consume some extra CPU time for nothing since the GC will do that job anyway. is sf.close() cpu critical ? Even with a clean up it shouldn't be bad, or ? /max Max Rydahl Andersen wrote: Hi guys, Any reason why we don't empty all the collections we are holding onto in t

Re: [Hibernate] sessionfactoryimpl.close()

2005-09-26 Thread Emmanuel Bernard
OTOH, this will consume some extra CPU time for nothing since the GC will do that job anyway. Max Rydahl Andersen wrote: Hi guys, Any reason why we don't empty all the collections we are holding onto in the sessionfactory ? Are we just letting that be up to the garbage collector to handle o