Canh Ngo pushed to branch feature/cmng-psp1-CHANNELMGR-566 at cms-community /
hippo-addon-channel-manager
Commits:
a6e48aba by Canh Ngo at 2016-04-07T12:24:05+02:00
CHANNELMGR-566: used Object.keys() and Array.find() to improve loops
Using Object.keys() and js functional to simplify loops
- - - - -
3 changed files:
- frontend-ng/src/angularjs/api/hst.service.js
- frontend-ng/src/angularjs/api/session.service.js
- frontend-ng/src/angularjs/channel/relevance/viewAs.controller.js
Changes:
=====================================
frontend-ng/src/angularjs/api/hst.service.js
=====================================
--- a/frontend-ng/src/angularjs/api/hst.service.js
+++ b/frontend-ng/src/angularjs/api/hst.service.js
@@ -92,12 +92,8 @@ export class HstService {
}
_serializeParams(params) {
- const str = [];
- for (const param in params) {
- if (params.hasOwnProperty(param)) {
-
str.push(`${encodeURIComponent(param)}=${encodeURIComponent(params[param])}`);
- }
- }
+ const str = Object.keys(params)
+ .map((param) =>
`${encodeURIComponent(param)}=${encodeURIComponent(params[param])}`);
return str.join('&');
}
=====================================
frontend-ng/src/angularjs/api/session.service.js
=====================================
--- a/frontend-ng/src/angularjs/api/session.service.js
+++ b/frontend-ng/src/angularjs/api/session.service.js
@@ -47,10 +47,6 @@ export class SessionService {
}
_serveInitCallbacks() {
- for (const id in this._initCallbacks) {
- if (this._initCallbacks.hasOwnProperty(id)) {
- this._initCallbacks[id]();
- }
- }
+ Object.keys(this._initCallbacks).forEach((id) =>
this._initCallbacks[id]());
}
}
=====================================
frontend-ng/src/angularjs/channel/relevance/viewAs.controller.js
=====================================
--- a/frontend-ng/src/angularjs/channel/relevance/viewAs.controller.js
+++ b/frontend-ng/src/angularjs/channel/relevance/viewAs.controller.js
@@ -51,13 +51,7 @@ export class ViewAsCtrl {
const oldSelectedVariantId = this.selectedVariant &&
this.selectedVariant.id;
if (oldSelectedVariantId) {
- delete this.selectedVariant;
- this.globalVariants.some((variant) => {
- if (variant.id === oldSelectedVariantId) {
- this.selectedVariant = variant;
- }
- return !!this.selectedVariant;
- });
+ this.selectedVariant = this.globalVariants.find((variant) => (variant.id
=== oldSelectedVariantId));
}
// fallback to "Default" which is sorted first by the backend.
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/a6e48aba3b25a5842f0aad052f6d6973a1af31ad
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
