Mathijs den Burger pushed to branch feature/visual-editing-psp1 at cms-community / hippo-addon-channel-manager
Commits: b73509a3 by Tobias Jeger at 2016-10-31T10:01:12+01:00 CHANNELMGR-966 Improve error handling in back-end - - - - - 217cbe5f by Tobias Jeger at 2016-11-02T11:43:13+01:00 CHANNELMGR-966 Remove session refresh invocations After discussing the current use of session.refresh() with Ate and Ard, we concluded that we can best document the session to be "invocation scoped", i.e. the session is created before the invocation of a DocumentsService or DocumentTypesService method, and avoid the session.refresh() calls, as they consume quite some performance. - - - - - 5302ccf5 by Tobias Jeger at 2016-11-02T11:43:43+01:00 CHANNELMGR-966 Delete unused error code - - - - - 69269e87 by Tobias Jeger at 2016-11-02T12:15:29+01:00 CHANNELMGR-966 Remove unused editability check - - - - - dc1b4d77 by Tobias Jeger at 2016-11-02T12:17:57+01:00 CHANNELMGR-966 Remove TODO These two constants are also defined in the CMS API. I considered moving them to the repository and sharing them, but the repository is currently unaware of these "resource bundle groups" and terminology, and changing the API would be a lot of hassle. I also don't want to depend on the CMS (API) in the content service, so I figured duplicating this here would be the least bad option. - - - - - 3e8e0066 by Tobias Jeger at 2016-11-02T17:14:06+01:00 CHANNELMGR-966 Improve validation and error reporting on Update Split up the writing logic into a writing part (throw exception if value doesn't match document type) and a validation part (limited to required validator for now). Upon Update, we push the values onto the draft variant, save to the repository, validate, and if all is well copy the changes to the preview variant. - - - - - e0e9cf2f by Tobias Jeger at 2016-11-02T21:56:57+01:00 CHANNELMGR-966 Add unit tests for validation of compound fields Also generally improve readability of unit tests by using assertTrue, assertFalse and assertNull. - - - - - 89c8ffbb by Mathijs den Burger at 2016-11-04T09:53:19+01:00 CHANNELMGR-966 Improve error codes, make impl's package-private - - - - - c4ccc2c2 by Mathijs den Burger at 2016-11-04T10:37:12+01:00 CHANNELMGR-966 Refactor writeTo into smaller sub-methods - - - - - 861c8a16 by Mathijs den Burger at 2016-11-04T10:49:20+01:00 CHANNELMGR-966 Fix validation of required multiple string - - - - - 6603e69a by Mathijs den Burger at 2016-11-04T11:03:46+01:00 CHANNELMGR-966 Refactor CompoundFieldType#writeTo into smaller pieces - - - - - 7c1c3a54 by Mathijs den Burger at 2016-11-04T11:30:17+01:00 CHANNELMGR-966 Reintegrate feature/visual-editing-psp1-CHANNELMGR-966 - - - - - 30 changed files: - content-service/src/main/java/org/onehippo/cms/channelmanager/content/ContentResource.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/DocumentsService.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/DocumentsServiceImpl.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/model/Document.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/util/EditingUtils.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/ContentTypeContext.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/DocumentTypesService.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/DocumentTypesServiceImpl.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/field/type/CompoundFieldType.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/field/type/FieldType.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/field/type/StringFieldType.java - + content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/field/validation/ValidationErrorInfo.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/util/LocalizationUtils.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/OperationFailedException.java → content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/BadRequestException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/model/ErrorInfo.java → content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ErrorInfo.java - + content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ErrorWithPayloadException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/DocumentTypeNotFoundException.java → content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/ForbiddenException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/document/DocumentNotFoundException.java → content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/InternalServerErrorException.java - content-service/src/main/java/org/onehippo/cms/channelmanager/content/documenttype/ContentTypeException.java → content-service/src/main/java/org/onehippo/cms/channelmanager/content/error/NotFoundException.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/ContentResourceTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/ManagedUserSessionInvokerTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/DocumentsServiceImplTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/document/util/EditingUtilsTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/documenttype/ContentTypeContextTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/documenttype/field/type/CompoundFieldTypeTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/documenttype/field/type/StringFieldTypeTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/documenttype/util/FieldTypeUtilsTest.java - content-service/src/test/java/org/onehippo/cms/channelmanager/content/documenttype/util/LocalizationUtilsTest.java - content-service/src/test/resources/available-document.json - content-service/src/test/resources/empty-document.json The diff was not included because it is too large. View it on GitLab: https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/abbb589a1c6551a48928e845acbbd6381fc5a87e...7c1c3a54de1d1869064ab67acf1f29e792f01e6c
_______________________________________________ Hippocms-svn mailing list Hippocms-svn@lists.onehippo.org https://lists.onehippo.org/mailman/listinfo/hippocms-svn
