Mark Lenser pushed to branch feature/visual-editing-psp1-CHANNELMGR-970 at
cms-community / hippo-addon-channel-manager
Commits:
76865e69 by Mark at 2016-11-07T16:15:37+01:00
CHANNELMGR-970 add aria-label
- - - - -
62610190 by Mark at 2016-11-07T16:18:59+01:00
CHANNELMGR-970 aria-label
- - - - -
02102678 by Mark at 2016-11-07T16:21:28+01:00
CHANNELMGR-970 move comment
- - - - -
f6918f63 by Mark at 2016-11-07T17:13:52+01:00
CHANNELMGR-970 return empty array if the value cannot be found - for cases like
optional recursion
- - - - -
2 changed files:
-
frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js
- frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html
Changes:
=====================================
frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js
=====================================
---
a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js
+++
b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.component.js
@@ -26,7 +26,10 @@ export class ChannelFieldsCtrl {
}
getFieldAsArray(fieldId) {
- const field = this.fieldValues[fieldId] || [];
+ let field = this.fieldValues[fieldId];
+ if (typeof field === 'undefined') {
+ field = [];
+ }
return angular.isArray(field) ? field : [field];
}
=====================================
frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html
=====================================
--- a/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html
+++ b/frontend-ng/src/angularjs/channel/sidePanels/rightSidePanel/fields.html
@@ -45,8 +45,8 @@
</channel-fields>
</div>
+ <!-- other cases -->
<div ng-switch-default>
- <!-- other cases -->
<md-input-container ng-if="::!$ctrl.isEmptyMultiple(fieldType)"
class="md-block qa-field"
ng-class="::{'form-field-multiple':
fieldType.multiple}"
@@ -61,18 +61,21 @@
ng-if="fieldType.multiple"
ng-model="$ctrl.fieldValues[fieldType.id][$index]"
placeholder=""
+ aria-label="{{::fieldType.displayName}}"
ng-focus="$ctrl.onFieldFocus(fieldType)"
ng-blur="$ctrl.onFieldBlur(fieldType)">
<input ng-switch-when="STRING"
ng-if="!fieldType.multiple"
ng-model="$ctrl.fieldValues[fieldType.id]"
placeholder=""
+ aria-label="{{::fieldType.displayName}}"
ng-focus="$ctrl.onFieldFocus(fieldType)"
ng-blur="$ctrl.onFieldBlur(fieldType)">
<textarea ng-switch-when="MULTILINE_STRING"
ng-if="fieldType.multiple"
ng-model="$ctrl.fieldValues[fieldType.id][$index]"
placeholder=""
+ aria-label="{{::fieldType.displayName}}"
md-no-resize
ng-focus="$ctrl.onFieldFocus(fieldType)"
ng-blur="$ctrl.onFieldBlur(fieldType)">
@@ -81,6 +84,7 @@
ng-if="!fieldType.multiple"
ng-model="$ctrl.fieldValues[fieldType.id]"
placeholder=""
+ aria-label="{{::fieldType.displayName}}"
md-no-resize
ng-focus="$ctrl.onFieldFocus(fieldType)"
ng-blur="$ctrl.onFieldBlur(fieldType)">
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/compare/d27c4346a83b2e8b18a1e95287bdc820991aacbf...f6918f639dd320cda2c81c0b27726ecc4889742f
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
