Bert Leunis pushed to branch feature/HSTTWO-4208 at cms-community /
hippo-site-toolkit
Commits:
a617a567 by Bert Leunis at 2018-02-02T13:48:16+01:00
HSTTWO-4208 keep hippobean attribute in the tag lowercase, like as in other tags
- - - - -
3 changed files:
- client/src/main/java/org/hippoecm/hst/tag/HstManageContentTag.java
- client/src/main/resources/META-INF/hst-core.tld
- client/src/test/java/org/hippoecm/hst/tag/HstManageContentTagTest.java
Changes:
=====================================
client/src/main/java/org/hippoecm/hst/tag/HstManageContentTag.java
=====================================
--- a/client/src/main/java/org/hippoecm/hst/tag/HstManageContentTag.java
+++ b/client/src/main/java/org/hippoecm/hst/tag/HstManageContentTag.java
@@ -299,7 +299,7 @@ public class HstManageContentTag extends TagSupport {
this.defaultPath = defaultPath;
}
- public void setHippoBean(final HippoBean hippoBean) {
+ public void setHippobean(final HippoBean hippoBean) {
this.hippoBean = hippoBean;
}
=====================================
client/src/main/resources/META-INF/hst-core.tld
=====================================
--- a/client/src/main/resources/META-INF/hst-core.tld
+++ b/client/src/main/resources/META-INF/hst-core.tld
@@ -718,7 +718,7 @@
<body-content>JSP</body-content>
<attribute>
<description>Bean for existing document.</description>
- <name>hippoBean</name>
+ <name>hippobean</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
<type>org.hippoecm.hst.content.beans.standard.HippoBean</type>
=====================================
client/src/test/java/org/hippoecm/hst/tag/HstManageContentTagTest.java
=====================================
--- a/client/src/test/java/org/hippoecm/hst/tag/HstManageContentTagTest.java
+++ b/client/src/test/java/org/hippoecm/hst/tag/HstManageContentTagTest.java
@@ -145,7 +145,7 @@ public class HstManageContentTagTest {
@Test
public void documentFromHandle() throws Exception {
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -163,7 +163,7 @@ public class HstManageContentTagTest {
@Test
public void documentFromVariantBelowHandle() throws Exception {
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -182,7 +182,7 @@ public class HstManageContentTagTest {
@Test
public void documentWithoutCanonicalNodeOutputsNothing() throws Exception {
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final HippoNode handle = createMock(HippoNode.class);
expect(document.getNode()).andReturn(handle);
@@ -198,7 +198,7 @@ public class HstManageContentTagTest {
@Test
public void documentWithoutHandleNodeOutputsNothing() throws Exception {
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
expect(document.getNode()).andReturn(root);
@@ -212,7 +212,7 @@ public class HstManageContentTagTest {
@Test
public void exceptionWhileReadingUuidOutputsNothing() throws Exception {
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final HippoNode brokenNode = createMock(HippoNode.class);
expect(document.getNode()).andReturn(brokenNode).anyTimes();
@@ -311,7 +311,7 @@ public class HstManageContentTagTest {
tag.setParameterName("absPath");
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -343,7 +343,7 @@ public class HstManageContentTagTest {
tag.setParameterName("relPath");
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -372,7 +372,7 @@ public class HstManageContentTagTest {
tag.setParameterName("absPath");
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -399,7 +399,7 @@ public class HstManageContentTagTest {
tag.setParameterName("absPath");
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
@@ -445,7 +445,7 @@ public class HstManageContentTagTest {
tag.setParameterName("newsDocument");
final HippoBean document = createMock(HippoBean.class);
- tag.setHippoBean(document);
+ tag.setHippobean(document);
final MockNode root = MockNode.root();
final MockNode handle = root.addNode("document",
HippoNodeType.NT_HANDLE);
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-site-toolkit/commit/a617a56714a71a5527d62677fe55bc8aefdc5779
---
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-site-toolkit/commit/a617a56714a71a5527d62677fe55bc8aefdc5779
You're receiving this email because of your account on code.onehippo.org.
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
