Re: [Hipsec] Ben Campbell's No Objection on draft-ietf-hip-rfc4423-bis-19: (with COMMENT)

2019-01-06 Thread Miika Komu
Hi Ben,

On 5/10/18 05:53, Ben Campbell wrote:
> Ben Campbell has entered the following ballot position for
> draft-ietf-hip-rfc4423-bis-19: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-hip-rfc4423-bis/
> 
> 
> 
> --
> COMMENT:
> --
> 
> I have mostly just reviewed the diff from RFC4423. My comments are mostly
> editorial.
> 
> First, a minor rant that I don't expect to be addressed at this point in the
> process; I mainly say this to try to discourage it future bis drafts: There 
> are
> quite a few changes from 4423 that are entirely stylistic, but do not
> materially change the content or improve readability. I wish people wouldn't 
> do
> that, because it makes it harder to review material changes with the diff
> tools. (I will only point out such changes where I think the original was more
> correct.)

apologies for this!

> -General: There seems to have been a systematic attempt to remove hyphens from
> compound adjectives. There also seems to be a systematic attempt to change
> headings from title case to normal sentence case.  I suspect the RFC editor
> will change those all back.

(Adam already asked to fix a number of compound adjectives)

> Abstract: The abstract manages to completely avoid saying what this namespace
> is _for_. (Yes, I realize that is old text :-) )

I changed the first sentence to:

This memo describes the Host Identity (HI) namespace, that provides a
cryptographic namespace to applications, and the associated protocol
layer, the Host Identity Protocol, located between the
internetworking and transport layers, that supports end-host
mobility, multihoming and NAT traversal.

Is this ok for you?

> §1, first paragraph: s/ "try and do"/"try to do"
> 
> §4.2: Please mention the HIT abbreviation in the text, not just the heading.
> (The text should make sense even without the headings.)
> 
> §5:
> - third paragraph: Missing articles before "Left" and "right".
> - 2nd to last paragraph: Missing article before "HIP layer" (multiple
> instances).

fixed, thanks!

___
Hipsec mailing list
Hipsec@ietf.org
https://www.ietf.org/mailman/listinfo/hipsec


Re: [Hipsec] Adam Roach's No Objection on draft-ietf-hip-rfc4423-bis-19: (with COMMENT)

2019-01-06 Thread Miika Komu
Hi Adam,

On 5/10/18 02:34, Adam Roach wrote:
> Adam Roach has entered the following ballot position for
> draft-ietf-hip-rfc4423-bis-19: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-hip-rfc4423-bis/
> 
> 
> 
> --
> COMMENT:
> --
> 
> Thanks for everyone's work on updating RFC 4423.

thanks for comments!

> In general, I agree with Mirja's point that section 11 seems a bit disjoint
> from the rest of the document, and would be better served as an appendix. It's
> also somewhat jarring to have a document whose abstract talks about a "new
> namespace" and a "new protocol layer," which goes on to describe conclusions
> from twelve years of deployment experience. I would recommend re-working all
> uses of the word "new" (which, in most cases, can be achieved by either
> removing the word "new" from sentences, or replacing it with "HIP").

Agreed. I replaced "new" (namespace/layer) to "HI/additional" (depending 
on the context) throughout the document.

> The remainder of my comments are editorial nits.
> 
> ---
> 
> §2.1:
> 
>>   +---+---+
>>   | Term  | Explanation   |
>>   +---+---+
>>   | Public key| The public key of an asymmetric cryptographic key |
>>   |   | pair.  Used as a publicly known identifier for|
>>   |   | cryptographic identity authentication.  Public is |
>>   |   | a a relative term here, ranging from "known to|
>>   |   | peers only" to "known to the world."  |
> 
> Nit: this text contains a doubled "a" ("...a a relative...").

thanks

> ---
> §2.2:
> 
> Nit: The change in spacing in this table makes certain terms difficult to read
> (e.g., "HIP base exchange HIP packet" appears to be a single term until the
> table is closely examined.) Consider reverting to the spacing from RFC 4423.

done

> ---
> 
> §3.1:
> 
>>   o  The names should have a fixed length representation, for easy
> 
> Nit: "fixed-length" is a compound adjective, and should be hyphenated.
> cf. https://www.google.com/search?q=compound+adjective
> 
>>  (e.g the TCB).
> 
> Nit: The conventional form would call for "(e.g., the TCB)"
> cf. https://www.google.com/search?q="e.g."+punctuation+comma
> 
>> o The names should be long lived, but replaceable at any time. This
> 
> "long-lived"
> 
>> designed, it can deliver all of the above stated requirements.
> 
> "above-stated"

fixed, thanks

> ---
> 
> §4:
> 
>>   In theory, any name that can claim to be 'statistically globally
>>   unique' may serve as a Host Identifier.  In the HIP architecture, the
>>   public key of a private-public key pair has been chosen as the Host
>>   Identifier because it can be self managed and it is computationally
> 
> "self-managed"

fixed

> ---
> 
> §6.5:
> 
>>   The control plane between two hosts is terminated using a secure two
>>   message exchange as specified in base exchange specification
> 
> "two-message"

fixed

> ---
> 
> §7:
> 
>>   control plane, protected by asymmetric key cryptography.  Also, S-RTP
>>   has been considered as the data encapsulation protocol [hip-srtp].
> 
> "SRTP" rather than "S-RTP".

fixed

> ---
> 
> §8:
> 
>>   Besides this "native" NAT traversal mode for HIP, other NAT traversal
>>   mechanisms have been successfully utilized, such as Teredo
>>   [varjonen-split].
> 
> Please cite RFC 4380 for "Teredo." e.g.:
> 
> Besides this "native" NAT traversal mode for HIP, other NAT traversal
> mechanisms have been successfully utilized, such as Teredo [RFC4380],
> as described in [varjonen-split].

changed this to:

  such as Teredo [RFC4380]
(as described in further detail in [varjonen-split]).


> ---
> 
> §8:
> 
>>   can map to a single IP address on a