[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730419#action_12730419
]
Namit Jain commented on HIVE-555:
-
+1
looks good - am running tests right now
create
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729305#action_12729305
]
Namit Jain commented on HIVE-555:
-
Agreed, that is a separate problem which also exists
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729322#action_12729322
]
Namit Jain commented on HIVE-555:
-
The tests fail right now.
In the new test create_udaf.q,
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729332#action_12729332
]
Namit Jain commented on HIVE-555:
-
Confirmed the issue above: filed a new jira for that
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728921#action_12728921
]
Namit Jain commented on HIVE-555:
-
Mostly looks good - I had a couple of minor comments.
1.
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728989#action_12728989
]
Min Zhou commented on HIVE-555:
---
1. I thought it would be a common function for generic udf
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729004#action_12729004
]
Zheng Shao commented on HIVE-555:
-
@HIVE-555-3.patch.
Can we change the error messages to
[
https://issues.apache.org/jira/browse/HIVE-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729009#action_12729009
]
Min Zhou commented on HIVE-555:
---
@Zheng
It would involved some logic out of the FuctionTask.