Yes, that is weird. You're quoting vigra code,
...
#if _MSC_VER >= 1900 || __cplusplus >= 201103L
noexcept(false)
#else
throw(PreconditionViolation)
#endif
...
and given that enblend uses c++17, the offending line shouldn't be used.
Does that problem not occur without my
@Bruno: Are you building with automake or with CMake? (On Ubuntu with
CMake it works. But it seems they are providing a patched vigra library,
where this offending line is missing.)
@Lukas: I applied now most of your patches and pushed the changes to the
repository. Thank you again for the
Yes, I replaced the `throw(PreconditionViolation)` with
`noexcept(false)` in both vigra locations and now enblend builds.
I'm using enblend cmake, as the autoconf stuff needed bootstrapping and I
couldn't remember how to do it.
Haven't tested the bugfix yet, I seem to remember I created test
I can't get the latest mercurial with patches to build, this doesn't
really make sense to me as enblend requires c++17:
```
/usr/include/vigra/separableconvolution.hxx:1413:13: error: ISO C++17 does not
allow dynamic exception specifications
1413 | throw(PreconditionViolation)
It also passes the test case I uploaded here:
https://bugs.launchpad.net/enblend/+bug/785803/comments/8
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/2053287
Title:
sometimes there are
Can confirm that the patched enblend passes all the tests that I
uploaded here:
https://bugs.launchpad.net/enblend/+bug/721136/comments/18
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/2053287
Thanks for testing.
I also closed the mentioned tickets.
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/2053287
Title:
sometimes there are black patches/corners in blended images
Status in
Fixes with changes in #2053287
** Changed in: enblend
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/721136
Title:
enblend creates an unexplainable
Fixes with changes in #2053287
** Changed in: enblend
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/785803
Title:
Enblend --no-optimize produces
Thanks so much for fixing this bug. What was the underlying problem?
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Enblend.
https://bugs.launchpad.net/bugs/721136
Title:
enblend creates an unexplainable black area.
Status in
Thank you for merging and testing!
The part that you omitted wasn't very important, but I am surprised that it
causes issues with msvc (I had not tested that).
I am not surprised, but slightly relieved that not only my but also your test
cases pass!
--
You received this bug notification
The bug was what we had discussed on the hugin mailing list four years
ago: https://groups.google.com/g/hugin-ptx/c/IgglWhsUCEQ/m/6bUu_YQpCAAJ
tldr: one may generate a seam line such that pixels are included from an
image that are out of bounds wrt that image.
This fix only affects the blending
I'm not using msvc. This error is with fedora, but it looks like vigra
in Ubuntu has already been patched to support c++17. The fedora vigra
maintainer needs to copy some Ubuntu patches.
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to
@Bruno Since last autumn (~September) main line vigra should support
c++17, but any distribution release is of course likely to not have
included that yet. But I guess it will fix itself in Fedora some time.
(wrt msvc, I was referring to what Thomas wrote.)
--
You received this bug notification
14 matches
Mail list logo
