[Hugin-devs] [Bug 1778802] Re: PATCH: speed improvements

2019-01-26 Thread tmodes
** Changed in: hugin Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1778802 Title: PATCH: speed improvements Status in Hugin: Fix Released Bug des

[Hugin-devs] [Bug 1778802] Re: PATCH: speed improvements

2018-06-30 Thread tmodes
Thanks again. I committed most patches to repository (some were slightly modified). For ImageVariableGroup.patch: I made Panorama::getImage inline. GetImage should only return the address of the SrcPanoImage class, nothing more is happen in this function. I don't know why this should be so expens

[Hugin-devs] [Bug 1778802] Re: PATCH: speed improvements

2018-06-29 Thread Vladimir Nadvornik
I found one problem with ImageVariable.patch: MaskPolygon::parsePolygonString creates MaskPolygon instance without initialized bounding box. Before it was fixed by operator=, with ImageVariable.patch the instance is shared or copied with default copy constructor so it never gets fixed and masks

[Hugin-devs] [Bug 1778802] Re: PATCH: speed improvements

2018-06-27 Thread tmodes
Thanks you for your work. Some comments: ImageVariable.patch: This I need to check. This is a big change and I want to understand it before committing it. ImageVariableGroup.patch: This code and similar one is used at several places. Would it also help to inline the getimage function to achieve t

[Hugin-devs] [Bug 1778802] Re: PATCH: speed improvements

2018-06-27 Thread tmodes
** Patch added: "New initialization of members of SrcPanoImage class" https://bugs.launchpad.net/hugin/+bug/1778802/+attachment/5157128/+files/SrcPanoImage_init.patch -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs