[Hugin-devs] [Bug 679939] Re: add quick crop

2023-04-16 Thread Alex Kent Hajnal
I've created a patch that implements the 'outside' autocrop. See https://bugs.launchpad.net/hugin/+bug/2016362 -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679939 Title: add quick crop

[Hugin-devs] [Bug 679939] Re: add quick crop

2023-04-16 Thread tmodes
- A reset crop button (removing all cropping is currently quite fiddly). - Some preset grid overlays for composition (rule of thirds, corner diagonals, golden ratio etc...). These were already implemented in 2011 - Shift-drag at the centre would move only horizontally or vertically similar to

[Hugin-devs] [Bug 2016362] Re: Feature request: Add "Fit crop around images" button

2023-04-16 Thread tmodes
*** This bug is a duplicate of bug 679939 *** https://bugs.launchpad.net/bugs/679939 > This was done for speed (see below). As I understand it, for > non-masked/non-cropped images _some_ point on the source image's edge will be > at its largest/smallest projected X/Y position in the final

[Hugin-devs] [Bug 2016362] Re: Feature request: Add "Fit crop around images" button

2023-04-16 Thread tmodes
*** This bug is a duplicate of bug 679939 *** https://bugs.launchpad.net/bugs/679939 Testing only the first/last row/column of each image is not enough. It will fail e.g. for fisheye images and images with crop or masks. Also please use only whitespace for indentation. The patch contains

[Hugin-devs] [Bug 2016362] Re: Feature request: Add "Fit crop around images" button

2023-04-16 Thread Alex Kent Hajnal
*** This bug is a duplicate of bug 679939 *** https://bugs.launchpad.net/bugs/679939 Attached is the patch to add this functionality. It adds a new "Fit Crop Around Images" button below the "Fit Crop to Images" button on the "Stitcher" tab. The code crops the panorama so that all source

[Hugin-devs] [Bug 2016362] Re: Feature request: Add "Fit crop around images" button

2023-04-16 Thread Alex Kent Hajnal
*** This bug is a duplicate of bug 679939 *** https://bugs.launchpad.net/bugs/679939 Thanks for the quick response. Some questions for you: > Testing only the first/last row/column of each image is not enough. This was done for speed (see below). As I understand it, for non-

[Hugin-devs] [Bug 2016362] Re: Feature request: Add "Fit crop around images" button

2023-04-16 Thread Alex Kent Hajnal
*** This bug is a duplicate of bug 679939 *** https://bugs.launchpad.net/bugs/679939 ** Patch added: "Fixed indents, removed stray comments from constructors" https://bugs.launchpad.net/hugin/+bug/2016362/+attachment/5664416/+files/CalculateMaximalROI.1.patch -- You received this bug