[Hugin-devs] [Bug 1802790] Re: [PATCH] proper check for sys/sysctl.h at build time
** Changed in: hugin Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1802790 Title: [PATCH] proper check for sys/sysctl.h at build time Status in Hugin: Fix Released Bug description: The "platform" part of "hugin_utils" has an hardcoded list of platforms where sys/sysctl.h is not present (basically Windows, and Solaris). This is because sys/sysctl.h is not a standard POSIX header. OTOH, there are more platforms without that header, for example GNU/Hurd. A better way is to check whether sys/sysctl.h exists, and include it only in that case. Attached there is a hg commit that does this. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1802790/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 1802790] Re: [PATCH] proper check for sys/sysctl.h at build time
Even better, thanks! -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1802790 Title: [PATCH] proper check for sys/sysctl.h at build time Status in Hugin: Fix Committed Bug description: The "platform" part of "hugin_utils" has an hardcoded list of platforms where sys/sysctl.h is not present (basically Windows, and Solaris). This is because sys/sysctl.h is not a standard POSIX header. OTOH, there are more platforms without that header, for example GNU/Hurd. A better way is to check whether sys/sysctl.h exists, and include it only in that case. Attached there is a hg commit that does this. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1802790/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 1802790] Re: [PATCH] proper check for sys/sysctl.h at build time
Thanks for the patch. But the code in the mentioned file was not used anymore. So I removed the whole file without the need to change the build system. ** Changed in: hugin Status: New => Fix Committed ** Changed in: hugin Milestone: None => 2018.2beta1 -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1802790 Title: [PATCH] proper check for sys/sysctl.h at build time Status in Hugin: Fix Committed Bug description: The "platform" part of "hugin_utils" has an hardcoded list of platforms where sys/sysctl.h is not present (basically Windows, and Solaris). This is because sys/sysctl.h is not a standard POSIX header. OTOH, there are more platforms without that header, for example GNU/Hurd. A better way is to check whether sys/sysctl.h exists, and include it only in that case. Attached there is a hg commit that does this. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1802790/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 1802790] Re: [PATCH] proper check for sys/sysctl.h at build time
** Patch added: "hg commit" https://bugs.launchpad.net/hugin/+bug/1802790/+attachment/5211515/+files/hugin-sys-sysctl.h.diff ** Attachment removed: "hg commit" https://bugs.launchpad.net/hugin/+bug/1802790/+attachment/5211514/+files/hugin-sys-sysctl.h.diff -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1802790 Title: [PATCH] proper check for sys/sysctl.h at build time Status in Hugin: New Bug description: The "platform" part of "hugin_utils" has an hardcoded list of platforms where sys/sysctl.h is not present (basically Windows, and Solaris). This is because sys/sysctl.h is not a standard POSIX header. OTOH, there are more platforms without that header, for example GNU/Hurd. A better way is to check whether sys/sysctl.h exists, and include it only in that case. Attached there is a hg commit that does this. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1802790/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
