Re: [hugin-ptx] Control Point dialog features

2022-02-01 Thread johnfi...@gmail.com
On Sunday, January 23, 2022 at 8:36:58 AM UTC-5 gunter.ko...@gmail.com wrote: > Do we really have to magnify all of the image if afterwards only a small > portion of the magnified image fits on the screen? For me that feels like > an use of something similar to wxScrolled: wxScrolled tells

Re: [hugin-ptx] Control Point dialog features

2022-01-23 Thread Gunter Königsmann
Do we really have to magnify all of the image if afterwards only a small portion of the magnified image fits on the screen? For me that feels like an use of something similar to wxScrolled: wxScrolled tells you what part of the image to render, you render that part and the rest happens by some

Re: [hugin-ptx] Control Point dialog features

2022-01-23 Thread johnfi...@gmail.com
I had misunderstood some memory use info, to conclude the images there were using 16 bytes per pixel. Actually it is only 3 bytes. The actual measure of the limit past which it fails is 2**27 pixels in the magnified image. I was incorrect thinking that was 2GB. So it makes even less sense than

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
I did a bit more code review and testing. I can't find anything in hugin itself that has that size in bytes in any form for any reason. hugin just hands off all that work to wx. I find it near impossible to believe wxImage would have such a bug. But I can't see how it can be anyplace outside

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
On Saturday, January 22, 2022 at 3:57:29 AM UTC-5 T. Modes wrote: > > This is not so trivial. The current implementation keeps the full scaled > image in memory. So a 800 % zoom will require several GB of RAM only for > the cp tab. > In my initial testing of the feature, something fails

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
Don't know if this absolutely needs a new thread. Similar issues in the mask dialog: 1) the scroll bars go away when not in use (generally nice) but can be hard to get back. Middle drag would be much simpler for the user. 2) I believe (from behavior, haven't checked code yet) that proximity

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread Bruno Postle
On Sat, 22 Jan 2022 at 11:46, T. Modes wrote: >> >> Basically, the fix is to only centre the current control point in the >> viewports on mouseup, currently it centres on mousedown. > > Okay, now I see. I tested with zoom set to fit. There is was not obviously. > Tried to fix in repository.

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
On Saturday, January 22, 2022 at 2:55:12 AM UTC-5 Florian Königstein wrote: > > If someone likes to change the code for the control point TAB window, I > have another wish: If there are very many images and control points, e.g. > hundrets or even 1000 images, it is annoyingly slow if one

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
On Saturday, January 22, 2022 at 4:40:11 AM UTC-5 bruno...@gmail.com wrote: > > Basically, the fix is to only centre the current control point in the > viewports on mouseup, currently it centres on mousedown. > When you described the problem, I wondered whether the fix might be as easy as

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread johnfi...@gmail.com
On Saturday, January 22, 2022 at 3:57:29 AM UTC-5 T. Modes wrote: > > This is not so trivial. The current implementation keeps the full scaled > image in memory. So a 800 % zoom will require several GB of RAM only for > the cp tab. Furthermore I would expect speed issue when drawing such big

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread T. Modes
Hi Bruno, bruno...@gmail.com schrieb am Samstag, 22. Januar 2022 um 10:40:11 UTC+1: > However if see a control point and want to move it, the obvious way to > do this is to just click and drag it in one go - this only works > properly if the control point I want to drag is *exactly* in the >

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread Gunter Königsmann
On MS Windows cmake only detects wxWidgets if wxWidgets *wasn't* built using cmake. The rest should work fine there, too, minus Windows having no standard paths to store all the libraries in and therefore needing to be told where to find them all. Am 22. Januar 2022 10:51:23 MEZ schrieb Bruno

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread Bruno Postle
On Sat, 22 Jan 2022 at 01:17, johnfine wrote: > On Friday, January 21, 2022 at 7:20:51 PM UTC-5 bruno...@gmail.com wrote: > > Without a clear statement of the original intent, there is no way I would try > to fix the code for removing the magnifier to behave as intended and > predictably. I'm

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread Bruno Postle
On Sat, 22 Jan 2022 at 08:57, T. Modes wrote: > bruno...@gmail.com schrieb am Samstag, 22. Januar 2022 um 01:20:51 UTC+1: >> >> When zoomed-in, if I go to drag a control point that is not in the >> centre of the viewport then the view jumps to centre the viewport on >> this location - but my mouse

Re: [hugin-ptx] Control Point dialog features

2022-01-22 Thread T. Modes
bruno...@gmail.com schrieb am Samstag, 22. Januar 2022 um 01:20:51 UTC+1: > On Fri, 21 Jan 2022 at 18:34, johnfine2017 wrote: > > > > I want to make a bunch of changes to the control point dialog. > > > 1) Max resolution. 200% really isn't enough for me to place control > points easily. I

Re: [hugin-ptx] Control Point dialog features

2022-01-21 Thread Florian Königstein
The effect of control points for 3+ images can also be simulated by placing several CPs for two images, e.g. one CP that connects image 1 and 2, one that connects image 2 and 3 and possibly one connecting image 1 and 3. Doing so, the optimizer is forced to align the images in the same way as if

Re: [hugin-ptx] Control Point dialog features

2022-01-21 Thread johnfi...@gmail.com
On Friday, January 21, 2022 at 7:20:51 PM UTC-5 bruno...@gmail.com wrote: > > I never quite understood what made the magnifier come and go, so > anything you can do to make this more predictable. > Without a clear statement of the original intent, there is no way I would try to fix the

Re: [hugin-ptx] Control Point dialog features

2022-01-21 Thread Bruno Postle
On Fri, 21 Jan 2022 at 18:34, johnfine2017 wrote: > > I want to make a bunch of changes to the control point dialog. > 1) Max resolution. 200% really isn't enough for me to place control points > easily. I don't know what puts me or my photos or my large high res displays > outside the usual

Re: [hugin-ptx] Control Point dialog features

2022-01-21 Thread johnfi...@gmail.com
Thanks for the feedback (nice to know it is not entirely my personal unusual take on UIs). More details on what problems you have (I assume not identical to mine) might help. You may give me more ideas on how to make it better for my own use and/or if I manage to fix my build I would be glad

Re: [hugin-ptx] Control Point dialog features

2022-01-21 Thread Gunter Königsmann
I'm just an user. But I seem to have the same problems with Control Points as you. Am 21. Januar 2022 19:34:06 MEZ schrieb "johnfi...@gmail.com" : >I want to make a bunch of changes to the control point dialog. >Maybe this is just for my own use. But if those in control of the project >think

[hugin-ptx] Control Point dialog features

2022-01-21 Thread johnfi...@gmail.com
I want to make a bunch of changes to the control point dialog. Maybe this is just for my own use. But if those in control of the project think any of these are good ideas, I'd be happy to go to the extra effort to do these changes in a way that can go into the official version (I'll need a bit